8000 feat: add Python 3.9 support by hanxiao · Pull Request #1802 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add Python 3.9 support #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2021
Merged

feat: add Python 3.9 support #1802

merged 2 commits into from
Jan 27, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jan 27, 2021 •
edited
Loading

closes #1253

@hanxiao hanxiao requested a review from a team as a code owner January 27, 2021 14:50
@jina-bot jina-bot added size/S area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping component/type labels Jan 27, 2021
JoanFM
JoanFM suggested changes Jan 27, 2021
View reviewed changes
@codecov
Copy link
codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #1802 (266b823) into master (994c13f) will decrease coverage by 7.11%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
- Coverage   85.64%   78.52%   -7.12%     
==========================================
  Files         136      136              
  Lines        6936     6942       +6     
==========================================
- Hits         5940     5451     -489     
- Misses        996     1491     +495
Impacted Files Coverage Δ
jina/types/sets/querylang.py 93.54% <60.00%> (-3.07%) ⬇️
jina/types/sets/document.py 85.98% <66.66%> (-10.18%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/optimizer.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/check.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/logger.py 0.00% <0.00%> (-85.72%) ⬇️
jina/parsers/export_api.py 0.00% <0.00%> (-85.72%) ⬇️
jina/optimizers/discovery.py 0.00% <0.00%> (-80.27%) ⬇️
jina/drivers/multimodal.py 36.11% <0.00%> (-55.56%) ⬇️
jina/drivers/predict.py 36.20% <0.00%> (-53.45%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994c13f...5c6dfdc. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 27, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1134, delta to last 3 avg.: -15%
  • 🐎🐎🐎🐎 query QPS at 72, delta to last 3 avg.: +126%

Breakdown

Version Index QPS Query QPS
current 1134 72
0.9.21 1373 31
0.9.20 1321 31

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao mentioned this pull request Jan 27, 2021
Closed
@hanxiao hanxiao merged commit f7fc6d7 into master Jan 27, 2021
@hanxiao hanxiao deleted the feat-py39-support branch January 27, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM requested changes

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Python 3.9 support
3 participants
@hanxiao @JoanFM @jina-bot
0