8000 test: optimizer multiflow by florian-hoenicke · Pull Request #1800 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: optimizer multiflow #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2021
Merged

test: optimizer multiflow #1800

merged 3 commits into from
Jan 28, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 27, 2021 13:04
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Jan 27, 2021
@florian-hoenicke florian-hoenicke changed the title test: optimizer multiflow draft test: optimizer multiflow Jan 27, 2021
@florian-hoenicke florian-hoenicke self-assigned this Jan 27, 2021
@florian-hoenicke florian-hoenicke marked this pull request as draft January 27, 2021 13:06
JoanFM
JoanFM reviewed Jan 27, 2021
View reviewed changes
Copy link
Contributor
@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it also be added with docker Pods?

@codecov
Copy link
codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #1800 (fa0d23b) into master (994c13f) will decrease coverage by 0.03%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1800      +/-   ##
==========================================
- Coverage   85.64%   85.60%   -0.04%     
==========================================
  Files         136      136              
  Lines        6936     6935       -1     
==========================================
- Hits         5940     5937       -3     
- Misses        996      998       +2
Impacted Files Coverage Δ
jina/optimizers/parameters.py 100.00% <ø> (ø)
jina/types/sets/querylang.py 93.54% <60.00%> (-3.07%) ⬇️
jina/types/sets/document.py 94.39% <66.66%> (-1.77%) ⬇️
jina/optimizers/flow_runner.py 95.65% <100.00%> (+8.69%) ⬆️
jina/drivers/querylang/select.py 82.75% <0.00%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994c13f...1fe5d77. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 27, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1162, delta to last 3 avg.: +0%
  • 😶 query QPS at 26, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1162 26
0.9.21 1160 26

Backed by latency-tracking. Further commits will update this comment.

maximilianwerk
maximilianwerk requested changes Jan 27, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can do the test with one flow file and once call index and once search. This also leverages our index/search setup.

JoanFM
JoanFM reviewed Jan 28, 2021
View reviewed changes
@jina-bot jina-bot added size/M and removed size/S labels Jan 28, 2021
@florian-hoenicke florian-hoenicke marked this pull request as ready for review January 28, 2021 13:59
maximilianwerk
maximilianwerk approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@florian-hoenicke florian-hoenicke merged commit 923c1bd into master Jan 28, 2021
@florian-hoenicke florian-hoenicke deleted the test-optimizer-multiflow branch January 28, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM left review comments

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees

@florian-hoenicke florian-hoenicke

Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florian-hoenicke @maximilianwerk @JoanFM @jina-bot
0