8000 fix: add warning by JoanFM · Pull Request #1804 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add warning #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2021
Merged

fix: add warning #1804

merged 2 commits into from
Jan 28, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jan 27, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner January 27, 2021 18:49
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jan 27, 2021
@JoanFM JoanFM mentioned this pull request Jan 27, 2021
Closed
@codecov
Copy link
codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #1804 (7c7c409) into master (f7fc6d7) will decrease coverage by 21.39%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1804       +/-   ##
===========================================
- Coverage   85.62%   64.23%   -21.40%     
===========================================
  Files         136      136               
  Lines        6942     6939        -3     
===========================================
- Hits         5944     4457     -1487     
- Misses        998     2482     +1484
Impacted Files Coverage Δ
jina/optimizers/parameters.py 0.00% <ø> (-100.00%) ⬇️
jina/parsers/helper.py 41.61% <33.33%> (-9.08%) ⬇️
jina/peapods/pods/helper.py 94.73% <100.00%> (-3.14%) ⬇️
jina/helloworld/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/components.py 0.00% <0.00%> (-100.00%) ⬇️
jina/jaml/parsers/default/v1.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fc6d7...2b268ad. Read the comment docs.

@JoanFM
Copy link
Contributor Author
JoanFM commented Jan 27, 2021

I will change a test to make it more robust to sharding in remote

@github-actions
Copy link
github-actions bot commented Jan 27, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1214, delta to last 3 avg.: +0%
  • 😶 query QPS at 31, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1214 31
0.9.22 1210 31
0.9.21 1205 31

Backed by latency-tracking. Further commits will update this comment.

hanxiao
hanxiao reviewed Jan 27, 2021
View reviewed changes
@JoanFM JoanFM force-pushed the fix-peas-identities branch from 4f5ba80 to 2b268ad Compare January 28, 2021 07:47
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Jan 28, 2021
@JoanFM JoanFM requested a review from hanxiao January 28, 2021 12:50
@JoanFM JoanFM merged commit ad9cc9e into master Jan 28, 2021
@JoanFM JoanFM deleted the fix-peas-identities branch January 28, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatStark CatStark CatStark approved these changes

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

@hanxiao hanxiao Awaiting requested review from hanxiao

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @hanxiao @CatStark @jina-bot
0