8000 fix(flow): terminate flow gracefully on error pod by hanxiao · Pull Request #1799 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix(flow): terminate flow gracefully on error pod #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 27, 2021
Merged

fix(flow): terminate flow gracefully on error pod #1799

merged 4 commits into from
Jan 27, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jan 27, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner January 27, 2021 09:01
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/flow labels Jan 27, 2021
@codecov
Copy link
codecov bot commented Jan 27, 2021 •
edited
Loading

Codecov Report

Merging #1799 (08ab7a4) into master (b5b0ab4) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1799      +/-   ##
==========================================
+ Coverage   85.45%   85.61%   +0.16%     
==========================================
  Files         135      135              
  Lines        6924     6926       +2     
==========================================
+ Hits         5917     5930      +13     
+ Misses       1007      996      -11
Impacted Files Coverage Δ
jina/flow/base.py 88.02% <100.00%> (+0.56%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.30% <0.00%> (+1.44%) ⬆️
jina/jaml/helper.py 93.84% <0.00%> (+1.53%) ⬆️
jina/peapods/runtimes/jinad/client.py 75.00% <0.00%> (+2.20%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 82.97% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b0ab4...1321ca4. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 27, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1098, delta to last 3 avg.: +0%
  • 😶 query QPS at 25, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1098 25
0.9.21 1093 25
0.9.20 1094 25

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 8d5e0c9 into master Jan 27, 2021
@hanxiao hanxiao deleted the fix-graceful-flow-termination branch January 27, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsergiy imsergiy Awaiting requested review from imsergiy

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/flow size/S
Projects
None yet
Milestone
No milestone
3E55
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0