8000 fix(daemon): export logs, delete workspaces, reenable distributed tests by deepankarm · Pull Request #1768 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(daemon): export logs, delete workspaces, reenable distributed tests #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 25, 2021
Merged

fix(daemon): export logs, delete workspaces, reenable distributed tests #1768

merged 11 commits into from
Jan 25, 2021

Conversation

deepankarm
Copy link
Contributor

No description provided.

@deepankarm deepankarm requested a review from a team as a code owner January 23, 2021 21:41
@deepankarm deepankarm marked this pull request as draft January 23, 2021 21:42
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/flow component/peapod labels Jan 23, 2021
@github-actions
Copy link
github-actions bot commented Jan 23, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1135, delta to last 3 avg.: +0%
  • 😶 query QPS at 26, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1135 26
0.9.20 1133 27

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Jan 23, 2021 •
edited
Loading

Codecov Report

Merging #1768 (ca48405) into master (af31c32) will increase coverage by 0.30%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
+ Coverage   85.44%   85.74%   +0.30%     
==========================================
  Files         135      135              
  Lines        6924     6933       +9     
==========================================
+ Hits         5916     5945      +29     
+ Misses       1008      988      -20
Impacted Files Coverage Δ
jina/optimizers/flow_runner.py 84.44% <ø> (ø)
jina/peapods/runtimes/jinad/client.py 78.98% <75.00%> (+6.59%) ⬆️
jina/flow/base.py 87.46% <87.50%> (-0.58%) ⬇️
jina/parsers/peapods/runtimes/distributed.py 100.00% <100.00%> (ø)
jina/peapods/runtimes/jinad/__init__.py 91.48% <100.00%> (+13.93%) ⬆️
jina/peapods/pods/helper.py 97.87% <0.00%> (+1.06%) ⬆️
jina/peapods/runtimes/asyncio/rest/app.py 91.17% <0.00%> (+1.96%) ⬆️
jina/importer.py 67.24% <0.00%> (+2.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af31c32...694380b. Read the comment docs.

hanxiao
hanxiao requested changes Jan 24, 2021
View reviewed changes
Copy link
Member
@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please note that fix(daemon): miscellaneous is unacceptable, it does not show any useful information. Our auto Release Note system relies on meaningful commit message, otherwise it is hard for everybody to track what is going on each PR and release.

@jina-bot jina-bot added size/L area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping component/docker and removed size/M labels Jan 24, 2021
@deepankarm
Copy link
Contributor Author
deepankarm commented Jan 24, 2021 •
edited
Loading

please note that fix(daemon): miscellaneous is unacceptable, it does not show any useful information. Our auto Release Note system relies on meaningful commit message, otherwise it is hard for everybody to track what is going on each PR and release.

Makes sense.

@jina-bot jina-bot added size/M and removed size/L labels Jan 24, 2021
@jina-bot jina-bot added size/L and removed size/M labels Jan 25, 2021
@deepankarm deepankarm changed the title fix(daemon): miscellaneous issues fix(daemon): export logs, delete workspaces, reenable distributed tests Jan 25, 2021
hanxiao
hanxiao reviewed Jan 25, 2021
View reviewed changes
jina/peapods/runtimes/jinad/__init__.py Outdated
@@ -2,7 +2,7 @@
import asyncio
from typing import Optional

from .client import PeaDaemonClient
from .client import PodDaemonClient
Copy link
Member
@hanxiao hanxiao Jan 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is no semantic change on Pea/PodDaemonClient, I believe this should stick to PeaDaemonClient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PodDaemonClient calls /pods which invokes a Pod. Any reason we were using PeaDaemonClient here?

@deepankarm deepankarm marked this pull request as ready for review January 25, 2021 10:51
JoanFM
JoanFM previously approved these changes Jan 25, 2021
View reviewed changes
@deepankarm deepankarm requested a review from hanxiao January 25, 2021 15:27
hanxiao
hanxiao reviewed Jan 25, 2021
View reviewed changes
hanxiao
hanxiao reviewed Jan 25, 2021
View reviewed changes
hanxiao
hanxiao reviewed Jan 25, 2021
View reviewed changes
@hanxiao hanxiao merged commit f570ef7 into master Jan 25, 2021
@hanxiao hanxiao deleted the fix-daemon-misc branch January 25, 2021 18:11
@hanxiao hanxiao mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao requested changes

@JoanFM JoanFM JoanFM left review comments

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

@Roshanjossey Roshanjossey Awaiting requested review from Roshanjossey

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/docker component/flow component/peapod size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepankarm @hanxiao @JoanFM @jina-bot
0