8000 fix(parser): add compress args back to cli by hanxiao · Pull Request #1766 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(parser): add compress args back to cli #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 23, 2021
Merged

fix(parser): add compress args back to cli #1766

merged 6 commits into from
Jan 23, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jan 23, 2021 •
edited by nan-wang
Loading

Breaking Changes #1606

@hanxiao hanxiao requested a review from a team as a code owner January 23, 2021 12:18
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/driver component/peapod component/proto component/type labels Jan 23, 2021
@codecov
Copy link
codecov bot commented Jan 23, 2021 •
edited
Loading

Codecov Report

Merging #1766 (bcd77d0) into master (780d626) will increase coverage by 0.03%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
+ Coverage   85.40%   85.44%   +0.03%     
==========================================
  Files         135      135              
  Lines        6926     6938      +12     
==========================================
+ Hits         5915     5928      +13     
+ Misses       1011     1010       -1
Impacted Files Coverage Δ
jina/parsers/client.py 100.00% <ø> (ø)
jina/parsers/peapods/pod.py 100.00% <ø> (ø)
jina/parsers/peapods/runtimes/container.py 100.00% <ø> (ø)
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/peapods/runtimes/zmq/zed.py 89.85% <75.00%> (-0.08%) ⬇️
jina/enums.py 95.94% <100.00%> (+0.02%) ⬆️
jina/flow/base.py 87.53% <100.00%> (+0.32%) ⬆️
jina/jaml/helper.py 92.30% <100.00%> (ø)
jina/parsers/peapods/runtimes/remote.py 100.00% <100.00%> (ø)
jina/parsers/peapods/runtimes/zed.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5d045...bcd77d0. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 23, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1262, delta to last 3 avg.: +0%
  • 😶 query QPS at 33, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1262 33
0.9.20 1266 33
0.9.19 1259 33

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/cli This issue/PR affects the command line interface label Jan 23, 2021
@hanxiao hanxiao merged commit 01d2be4 into master Jan 23, 2021
@hanxiao hanxiao deleted the fix-compress-cli branch January 23, 2021 16:11
@nan-wang nan-wang mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@BastinJafari BastinJafari Awaiting requested review from BastinJafari

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/driver component/flow component/jaml component/peapod component/proto component/resource component/type size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0