8000 fix(pods): remove random identity assignment by hanxiao · Pull Request #1755 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(pods): remove random identity assignment #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2021
Merged

fix(pods): remove random identity assignment #1755

merged 2 commits into from
Jan 21, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jan 21, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner January 21, 2021 23:15
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Jan 21, 2021
@codecov
Copy link
codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #1755 (3f734b9) into master (650f87e) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
- Coverage   85.18%   85.12%   -0.07%     
==========================================
  Files         134      134              
  Lines        6865     6862       -3     
==========================================
- Hits         5848     5841       -7     
- Misses       1017     1021       +4
Impacted Files Coverage Δ
jina/peapods/pods/helper.py 96.80% <ø> (-0.10%) ⬇️
jina/drivers/querylang/select.py 79.31% <0.00%> (-6.90%) ⬇️
jina/peapods/runtimes/zmq/zed.py 89.92% <0.00%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 650f87e...f0632be. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1233, delta to last 3 avg.: -27%
  • 😶 query QPS at 32, delta to last 3 avg.: -1%

Breakdown

Version Index QPS Query QPS
current 1233 32
0.9.18 1702 32
0.9.17 1714 32

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 65e30e1 into master Jan 21, 2021
@hanxiao hanxiao deleted the rm-random-identity branch January 21, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imsergiy imsergiy Awaiting requested review from imsergiy

@Yongxuanzhang Yongxuanzhang Awaiting requested review from Yongxuanzhang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0