docs: some cleanup #1745
Merged
docs: some cleanup #1745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a789fb9 to
0a691c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 85.55% 85.54% -0.02%
==========================================
Files 134 134
Lines 6834 6834
==========================================
- Hits 5847 5846 -1
- Misses 987 988 +1
Continue to review full report at Codecov.
|
JoanFM
approved these changes
Jan 21, 2021
deepankarm
reviewed
Jan 21, 2021
| @@ -224,7 +224,7 @@ def input_fn(): | |||
| input_fn = (b's' for _ in range(10)) | |||
| ``` | |||
|
|
|||
| > Please note that the current Flow API does not support using `index()` and `search()` together in the same `with` scope. This is because the workflow of `index()` and `search()` are usually different and you cannot use one workflow for both tasks. | |||
| > Please note that the current Flow API does not support using `index()` and `search()` together in the same `with` scope. This is because the workflow of `index()` and `search()` are usually different, and you cannot use one workflow for both tasks. | |||
There was a problem hiding this comment.
If itis about proper closure of Peas/Pods, it makes sense. If it is about multiple clients under the same scope, that is allowed.
There was a problem hiding this comment.
Interesting. However, the only thing i changed was a comma , lol
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes I did while reading a bit through the docs