8000 refactor: deprecate client and flow input aliases by JoanFM · Pull Request #1730 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: deprecate client and flow input aliases #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

refactor: deprecate client and flow input aliases #1730

merged 2 commits into from
Jan 20, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jan 20, 2021 •
edited by nan-wang
Loading

Deprecations #1728

@JoanFM JoanFM requested a review from a team as a code owner January 20, 2021 06:57
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs component/client component/flow labels Jan 20, 2021
@codecov
Copy link
codecov bot commented Jan 20, 2021 •
edited
Loading

Codecov Report

Merging #1730 (f4676ab) into master (d7fdc47) will decrease coverage by 4.82%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1730      +/-   ##
==========================================
- Coverage   85.65%   80.82%   -4.83%     
==========================================
  Files         134      134              
  Lines        6830     6817      -13     
==========================================
- Hits         5850     5510     -340     
- Misses        980     1307     +327
Impacted Files Coverage Δ
jina/clients/asyncio.py 71.42% <ø> (-6.35%) ⬇️
jina/flow/asyncio.py 60.00% <ø> (-8.19%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/parameters.py 0.00% <0.00%> (-89.78%) ⬇️
jina/optimizers/discovery.py 0.00% <0.00%> (-80.27%) ⬇️
jina/drivers/predict.py 37.28% <0.00%> (-52.55%) ⬇️
jina/drivers/querylang/queryset/dunderkey.py 54.90% <0.00%> (-45.10%) ⬇️
jina/executors/rankers/__init__.py 62.79% <0.00%> (-30.24%) ⬇️
jina/drivers/reduce.py 70.58% <0.00%> (-29.42%) ⬇️
jina/drivers/querylang/queryset/lookup.py 47.36% <0.00%> (-26.32%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7fdc47...50070fe. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 20, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1670, delta to last 3 avg.: +2%
  • 😶 query QPS at 29, delta to last 3 avg.: +3%

Breakdown

Version Index QPS Query QPS
current 1670 29
0.9.18 1600 27
0.9.17 1653 28

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM closed this Jan 20, 2021
@JoanFM JoanFM reopened this Jan 20, 2021
@JoanFM JoanFM closed this Jan 20, 2021
@JoanFM JoanFM reopened this Jan 20, 2021
bwanglzu
bwanglzu approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 5b86048 into master Jan 20, 2021
@JoanFM JoanFM deleted the remove-output_fn branch January 20, 2 8000 021 14:13
maximilianwerk pushed a commit that referenced this pull request Jan 21, 2021
@maximilianwerk
refactor: deprecate client and flow input aliases (#1730)
25a9c56
@JoanFM JoanFM mentioned this pull request Jan 22, 2021
Closed
@github-actions github-actions bot mentioned this pull request Jan 22, 2021
Merged
@nan-wang nan-wang mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwanglzu bwanglzu bwanglzu approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

@deepankarm deepankarm Awaiting requested review from deepankarm

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs component/client component/flow size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @bwanglzu @jina-bot
0