chore: update add() use case in readme #1723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 133 133
Lines 6861 6861
=======================================
Hits 5826 5826
Misses 1035 1035 Continue to review full report at Codecov.
|
maximilianwerk
pushed a commit
that referenced
this pull request
Jan 21, 2021
Co-authored-by: yongxuanzhang <yongxuanzhang93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old example of
.add(uses='docker://jinahub/pretrained-cnn:latest')is outdated since pretrained-cnn:latest doesn't exist in jinahub and will cause error.Change it with the most downloaded image
.add(uses='docker://jinahub/pod.encoder.dummy_mwu_encoder:0.0.6-0.9.3').