8000 fix: shard may be empty by JoanFM · Pull Request #1689 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: shard may be empty #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

fix: shard may be empty #1689

merged 1 commit into from
Jan 15, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jan 14, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner January 14, 2021 14:20
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Jan 14, 2021
@codecov
Copy link
codecov bot commented Jan 14, 2021 •
edited
Loading

Codecov Report

Merging #1689 (1e02785) into master (5530733) will decrease coverage by 20.50%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1689       +/-   ##
===========================================
- Coverage   84.20%   63.70%   -20.51%     
===========================================
  Files         132      132               
  Lines        6830     6832        +2     
===========================================
- Hits         5751     4352     -1399     
- Misses       1079     2480     +1401
Impacted Files Coverage Δ
jina/drivers/search.py 81.03% <50.00%> (-13.61%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/build.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/login.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/pushpull.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/request/common.py 0.00% <0.00%> (-100.00%) ⬇️
jina/optimizers/flow_runner.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/numpy.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/pytorch.py 0.00% <0.00%> (-100.00%) ⬇️
jina/types/ndarray/sparse/tensorflow.py 0.00% <0.00%> (-100.00%) ⬇️
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5530733...a00870f. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 14, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1678, delta to last 3 avg.: +5%
  • 😶 query QPS at 31, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1678 31
0.9.13 1586 31
0.9.12 1600 31

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM force-pushed the indexers-empty-shard branch from 39c8b95 to 8fcb371 Compare January 14, 2021 14:33
@jina-bot jina-bot added size/S area/testing This issue/PR affects testing and removed size/XS labels Jan 14, 2021
@JoanFM JoanFM linked an issue Jan 14, 2021 that may be closed by this pull request
TypeError('zip argument #2 must support iteration') #1684
Closed
@JoanFM JoanFM force-pushed the indexers-empty-shard branch from 8fcb371 to a00870f Compare January 14, 2021 14:37
@JoanFM JoanFM requested a review from cristianmtr January 14, 2021 17:30
nan-wang
nan-wang approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit fa47adb into master Jan 15, 2021
@nan-wang nan-wang deleted the indexers-empty-shard branch January 15, 2021 01:04
@JoanFM JoanFM mentioned this pull request Jan 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@deepankarm deepankarm Awaiting requested review from deepankarm

@florian-hoenicke florian-hoenicke Awaiting requested review from florian-hoenicke

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError('zip argument #2 must support iteration')
3 participants
@JoanFM @nan-wang @jina-bot
0