ci: tag docker image with github run id #1679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 84.14% 84.39% +0.24%
==========================================
Files 132 132
Lines 6831 6831
==========================================
+ Hits 5748 5765 +17
+ Misses 1083 1066 -17
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
florian-hoenicke
previously approved these changes
Jan 13, 2021
hanxiao
requested changes
Jan 13, 2021
There was a problem hiding this comment.
- we dont have
${{ matrix.build_option }}, it is an empty value. This PR takes no effect. - use {{env.GITHUB_RUN_ID}}, Unique ID, Safe String, no escaping required
ci.yaml: jina:test-pip${{env.GITHUB_RUN_ID}}
python: uses=f'docker://jina:test-pip{os.environ[GITHUB_RUN_ID]}'
tests/__init__.py: os.environ['GITHUB_RUN_ID']=''
ref: https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables
hanxiao
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.