8000 refactor: unused definitions by florian-hoenicke · Pull Request #1660 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: unused definitions #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2021
Merged

refactor: unused definitions #1660

merged 2 commits into from
Jan 12, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod labels Jan 12, 2021
@codecov
Copy link
codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #1660 (f719651) into master (55ab38c) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   84.95%   84.88%   -0.08%     
==========================================
  Files         133      133              
  Lines        6948     6934      -14     
==========================================
- Hits         5903     5886      -17     
- Misses       1045     1048       +3
Flag Coverage Δ
cd ?
ci 84.88% <100.00%> (+41.44%) ⬆️
core 84.22% <100.00%> (-0.07%) ⬇️
integration 40.82% <0.00%> (-0.07%) ⬇️
jinad 40.82% <0.00%> (-2.61%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/helper.py 100.00% <ø> (+6.12%) ⬆️
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/proto/jina_pb2_grpc.py 78.94% <ø> (+8.57%) ⬆️
jina/peapods/runtimes/zmq/zed.py 90.41% <100.00%> (ø)
jina/logging/sse.py 92.18% <0.00%> (-3.13%) ⬇️
jina/importer.py 65.08% <0.00%> (-2.16%) ⬇️
jina/peapods/runtimes/jinad/api.py 74.34% <0.00%> (-0.66%) ⬇️
jina/flow/base.py 86.83% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0339e6d...f719651. Read the comment docs.

JoanFM
JoanFM suggested changes Jan 12, 2021
View reviewed changes
@github-actions
Copy link
github-actions bot commented Jan 12, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 2016, delta to last 3 avg.: +0%
  • 😶 query QPS at 37, delta to last 3 avg.: +0%

Breakdown

Version Index QPS Query QPS
current 2016 37
0.9.12 2012 37

Backed by latency-tracking. Further commits will update this comment.

@florian-hoenicke florian-hoenicke marked this pull request as ready for review January 12, 2021 11:52
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 12, 2021 11:52
@florian-hoenicke florian-hoenicke merged commit e1114fb into master Jan 12, 2021
@florian-hoenicke florian-hoenicke deleted the refactor-unused-definitions branch January 12, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@CatStark CatStark Awaiting requested review from CatStark

@r 5E73 utujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/peapod size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-hoenicke @JoanFM @jina-bot
0