8000 refactor: shadowing built ins by florian-hoenicke · Pull Request #1658 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: shadowing built ins #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2021
Merged

refactor: shadowing built ins #1658

merged 3 commits into from
Jan 12, 2021

Conversation

florian-hoenicke
Copy link
Member

No description provided.

@florian-hoenicke florian-hoenicke requested a review from a team as a code owner January 12, 2021 00:52
@codecov
Copy link
codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #1658 (2e3f82d) into master (55ab38c) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
- Coverage   84.95%   84.85%   -0.11%     
==========================================
  Files         133      133              
  Lines        6948     6940       -8     
==========================================
- Hits         5903     5889      -14     
- Misses       1045     1051       +6
Flag Coverage Δ
cd ?
ci 84.85% <100.00%> (+41.41%) ⬆️
core 84.19% <100.00%> (-0.10%) ⬇️
integration 40.79% <23.07%> (-0.10%) ⬇️
jinad 43.34% <23.07%> (-0.10%) ⬇️
unit 39.46% <23.07%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/proto/jina_pb2_grpc.py 78.94% <ø> (+8.57%) ⬆️
jina/docker/helper.py 74.50% <100.00%> (ø)
jina/executors/indexers/cache.py 97.14% <100.00%> (ø)
jina/parsers/helper.py 96.66% <100.00%> (ø)
jina/types/document/converters.py 96.87% <100.00%> (ø)
jina/logging/sse.py 92.18% <0.00%> (-3.13%) ⬇️
jina/importer.py 65.08% <0.00%> (-2.16%) ⬇️
jina/peapods/runtimes/jinad/api.py 74.34% <0.00%> (-0.66%) ⬇️
jina/flow/base.py 86.83% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0339e6d...2e3f82d. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 12, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1850, delta to last 3 avg.: +5%
  • 🐎🐎🐎🐎 query QPS at 36, delta to last 3 avg.: +12%

Breakdown

Version Index QPS Query QPS
current 1850 36
0.9.12 1754 32

Backed by latency-tracking. Further commits will update this comment.

JoanFM
JoanFM previously approved these changes Jan 12, 2021
View reviewed changes
CatStark
CatStark previously approved these changes Jan 12, 2021
View reviewed changes
hanxiao
hanxiao reviewed Jan 12, 2021
View reviewed changes
hanxiao
hanxiao requested changes Jan 12, 2021
View reviewed changes
Copy link
Member
@hanxiao hanxiao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep __exit__ signature as object.__exit__, others look good

@florian-hoenicke florian-hoenicke dismissed stale reviews from CatStark and JoanFM via 25e223f January 12, 2021 09:26
@hanxiao hanxiao merged commit f14bfa9 into master Jan 12, 2021
@hanxiao hanxiao deleted the refactor-shadowing-built-ins branch January 12, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@CatStark CatStark CatStark approved these changes

@JoanFM JoanFM JoanFM left review comments

@nan-wang nan-wang Awaiting requested review from nan-wang

@FionnD FionnD Awaiting requested review from FionnD

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/docker component/executor component/type executor/indexer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@florian-hoenicke @hanxiao @CatStark @JoanFM @jina-bot
0