8000 fix(proto): remove legacy unused fields by hanxiao · Pull Request #1655 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(proto): remove legacy unused fields #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2021
Merged

fix(proto): remove legacy unused fields #1655

merged 2 commits into from
Jan 11, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jan 11, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner January 11, 2021 19:24
@hanxiao hanxiao requested review from cristianmtr and JoanFM January 11, 2021 19:24
@hanxiao hanxiao linked an issue Jan 11, 2021 that may be closed by this pull request
Remove CallUnary from proto #1648
Closed
@github-actions
Copy link

This PR closes: #1647

@hanxiao hanxiao linked an issue Jan 11, 2021 that may be closed by this pull request
remove 'meta_info' from DocumentProto #1647
Closed
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/proto labels Jan 11, 2021
@jina-bot jina-bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 11, 2021
@codecov
Copy link
codecov bot commented Jan 11, 2021 •
edited
Loading

Codecov Report

Merging #1655 (f7b4f07) into master (55ab38c) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1655      +/-   ##
=====================
B1D7
=====================
+ Coverage   84.95%   85.01%   +0.05%     
==========================================
  Files         133      133              
  Lines        6948     6940       -8     
==========================================
- Hits         5903     5900       -3     
+ Misses       1045     1040       -5
Flag Coverage Δ
cd ?
ci 85.01% <ø> (+41.57%) ⬆️
core 84.35% <ø> (+0.06%) ⬆️
integration 40.86% <ø> (-0.03%) ⬇️
jinad 43.41% <ø> (-0.03%) ⬇️
unit 39.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/proto/jina_pb2_grpc.py 78.94% <ø> (+8.57%) ⬆️
jina/peapods/runtimes/jinad/api.py 74.34% <0.00%> (-0.66%) ⬇️
jina/peapods/runtimes/asyncio/rest/app.py 91.17% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ab38c...f7b4f07. Read the comment docs.

@hanxiao hanxiao merged commit 16b2ad5 into master Jan 11, 2021
@hanxiao hanxiao deleted the fix-1648-1647 branch January 11, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/proto size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CallUnary from proto remove 'meta_info' from DocumentProto
2 participants
@hanxiao @jina-bot
0