docs: crud #1461
docs: crud #1461
Conversation
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
745c8fb to
ff9d5ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #1461 +/- ##
==========================================
+ Coverage 85.62% 85.79% +0.16%
==========================================
Files 136 138 +2
Lines 6942 6981 +39
==========================================
+ Hits 5944 5989 +45
+ Misses 998 992 -6
Continue to review full report at Codecov.
|
ff9d5ad to
15d07b3
Compare
|
Want to me to do it as comments on file change tab? Or better I pull, edit and merge my changes into the branch @cristianmtr ? |
|
However is easier for you @alexcg1 |
Will merge my changes soon |
|
Nice work. I just added some very minor tweakage |
|
Don't forget to add it to |
6c0fdf6 to
64648c0
Compare
64648c0 to
26e68c2
Compare
docs/chapters/crud/index.md
Outdated
|
|
||
| 1. **Advanced Indexers** | ||
|
|
||
| `Faiss` & `Annoy` indexers don't support updates while querying. You can still use them in query mode, but you will not be able to add, delete, or update data. In order to do this, you will need use a `ref_indexer`-based approach. An example of this can be found [here](https://github.com/jina-ai/examples/master/advanced-vector-search) |
There was a problem hiding this comment.
This is not totally true, I think it works since Faiss and Annoy only start working while Querying.
There was a problem hiding this comment.
Since update and delete are operations on BaseNumpyIndexer these operations are possible on Faiss and Annoy instances.
There was a problem hiding this comment.
Re-wrote this part
26e68c2 to
ad137c0
Compare
|
Really well explained! |
Please leave feedback and suggestions
Waiting for all PR and tasks related to CRUD to be implemented and finalized before expanding this.
Relevant PRs/issues to be mentioned in here