8000 refactor(tests): refactoring on tests, remove and add tmpdir by JoanFM · Pull Request #1038 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(tests): refactoring on tests, remove and add tmpdir #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

refactor(tests): refactoring on tests, remove and add tmpdir #1038

merged 1 commit into from
Oct 7, 2020

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Oct 6, 2020

No description provided.

@jina-bot jina-bot added hacktoberfest size/M area/testing This issue/PR affects testing labels Oct 6, 2020
maximilianwerk
maximilianwerk previously approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment, which you can surely ignore, it LGTM

@codecov
Copy link
codecov bot commented Oct 6, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@f87abf9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1038   +/-   ##
=========================================
  Coverage          ?   79.55%           
=========================================
  Files             ?       64           
  Lines             ?     5028           
  Branches          ?        0           
=========================================
  Hits              ?     4000           
  Misses            ?     1028           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87abf9...4d69298. Read the comment docs.

bwanglzu
bwanglzu previously requested changes Oct 6, 2020
View reviewed changes
Copy link
Member
@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest looks good!

maximilianwerk
maximilianwerk approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member
@maximilianwerk maximilianwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 70f426d into master Oct 7, 2020
@JoanFM JoanFM deleted the tests-refactor branch October 7, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilianwerk maximilianwerk maximilianwerk approved these changes

@bwanglzu bwanglzu Awaiting requested review from bwanglzu

Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
4140
Development

Successfully merging this pull request may close these issues.
4 participants
@JoanFM @maximilianwerk @bwanglzu @jina-bot
0