feat: tree traversal for reverseQL, filterQL, selectQL #995
Conversation
There was a problem hiding this comment.
This looks good so far. Anyhow, there are lots of more appearances in the code, where the changed drivers are used. All of these places must be visited and changed (e.g. more tests in test_querylang_drivers.py). Basically, wherever one of the drivers appear together with granulartiy_range, adjacency_range, recur_on or recursion_order, there is some need for refactoring.
|
This PR would be merged after |
|
ok i merged #933 can you @rutujasurve94 merge master into this branch and try again? |
355839f to
ac1f551
Compare
| @@ -87,14 +87,14 @@ def validate(req): | |||
|
|
|||
| f = (Flow().add(uses='DummySegmenter') | |||
| .add( | |||
| uses='- !SortQL | {field: id, reverse: true, traversal_paths: [r, c, m]}')) | |||
| uses='- !SortQL | {field: id, reverse: true, traversal_paths: [\'c\']}')) | |||
There was a problem hiding this comment.
This test should not pass. It tests, whether all three thing (root docs, matches and chunks) are reversed. If you only reverse chunks, it should fail.
Furthermore, I'd prefer having a plain traversal_paths: [c] instead of escaping characters. It makes the code easier to read.
There was a problem hiding this comment.
Sure, reverted traversal_paths to [r, c, m]
dff04fb to
7c466e2
Compare
7c466e2 to
715bdc3
Compare
090e95c to
dc2efe1
Compare
* feat: switched to tree traversal for index driver * fix: better temporary folder handling
* feat: added tree traversal for search driver * fix: use_tree_traversal not a function parameter anymore
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
==========================================
- Coverage 79.61% 79.35% -0.27%
==========================================
Files 63 63
Lines 4960 4921 -39
==========================================
- Hits 3949 3905 -44
- Misses 1011 1016 +5
Continue to review full report at Codecov.
|
Added
traversal_pathsanduse_tree_traversalfor enabling default tree traversal for QL drivers:SelectQL, ReverseQL, ExcludeQL, filterQL