feat: allow to access parameters of data request wo loading data #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7a83db to
3b7442e
Compare
Codecov Report
@@ Coverage Diff @@
## master #4991 +/- ##
==========================================
- Coverage 87.92% 87.88% -0.05%
==========================================
Files 111 111
Lines 8862 8870 +8
==========================================
+ Hits 7792 7795 +3
- Misses 1070 1075 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohannesMessner
suggested changes
Jul 4, 2022
JohannesMessner
suggested changes
Jul 5, 2022
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
JoanFM
approved these changes
Jul 5, 2022
JohannesMessner
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pr is the direct follow up of #4950.
The last pr allow us to access the parameters of the DataRequest wo loading the data( DocumentArray).
We need sometime to set the parameters wo loading the data as well. Especially for #4939
What this pr do:
This PR allow to set the parameters wo loading the data.
Now the parameters property setters call proto_wo_data under the hood.
I refactor the code so that
_pb_bodycan either be a DataRequestProto or a DataRequestProtoWoData