8000 chore: remove lz4 reqs by JoanFM · Pull Request #4978 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove lz4 reqs #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2022
Merged

chore: remove lz4 reqs #4978

merged 2 commits into from
Jun 28, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 28, 2022 •
edited
Loading

Goals:
Issue from community installing jina because of this dependency, but seems not to be used anywhere anymore

@JoanFM JoanFM requested review from hanxiao and nan-wang as code owners June 28, 2022 09:45
@JoanFM JoanFM linked an issue Jun 28, 2022 that may be closed by this pull request
trying install thru pip nothing works #4968
Closed
@github-actions github-actions bot added size/S area/setup This issue/PR affects setting up Jina labels Jun 28, 2022
@JoanFM JoanFM closed this Jun 28, 2022
@JoanFM JoanFM reopened this Jun 28, 2022
@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/resource labels Jun 28, 2022
@codecov
Copy link
codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #4978 (086c3c5) into master (e33513e) will decrease coverage by 1.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4978      +/-   ##
==========================================
- Coverage   87.83%   86.10%   -1.74%     
==========================================
  Files         111      111              
  Lines        8763     8763              
==========================================
- Hits         7697     7545     -152     
- Misses       1066     1218     +152
Flag Coverage Δ
jina 86.10% <ø> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/flow/v1.py 63.15% <0.00%> (-35.09%) ⬇️
jina/clients/request/helper.py 74.46% <0.00%> (-21.28%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
jina/orchestrate/flow/base.py 81.49% <0.00%> (-8.90%) ⬇️
jina/clients/helper.py 92.85% <0.00%> (-7.15%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 94.55% <0.00%> (-5.45%) ⬇️
jina/clients/request/asyncio.py 78.94% <0.00%> (-5.27%) ⬇️
jina/clients/base/grpc.py 85.00% <0.00%> (-3.34%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 91.53% <0.00%> (-3.08%) ⬇️
jina/helper.py 78.37% <0.00%> (-2.56%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33513e...086c3c5. Read the comment docs.

@JoanFM JoanFM merged commit afa3892 into master Jun 28, 2022
@JoanFM JoanFM deleted the chore-remove-lz4-dependency branch June 28, 2022 10:44
samsja pushed a commit that referenced this pull request Jun 29, 2022
chore: remove lz4 reqs (#4978)
380ae6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trying install thru pip nothing works
3 participants
@JoanFM @hanxiao @jina-bot
0