8000 fix(import): remove early check file exist by hanxiao · Pull Request #4977 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(import): remove early check file exist #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2022
Merged

fix(import): remove early check file exist #4977

merged 2 commits into from
Jun 28, 2022

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 28, 2022 •
edited
Loading

PathImporter.add_modules(*mod) did the complete path internally, no need for this outside line

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/jaml labels Jun 28, 2022
@codecov
Copy link
codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #4977 (d828b5f) into master (e33513e) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4977      +/-   ##
==========================================
- Coverage   87.83%   87.74%   -0.10%     
==========================================
  Files         111      111              
  Lines        8763     8772       +9     
==========================================
  Hits         7697     7697              
- Misses       1066     1075       +9
Flag Coverage Δ
jina 87.74% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/helper.py 83.33% <100.00%> (+0.12%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/serve/networking.py 86.13% <0.00%> (-0.80%) ⬇️
jina/orchestrate/flow/base.py 89.83% <0.00%> (-0.57%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 96.07% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33513e...d828b5f. Read the comment docs.

@JoanFM
Copy link
Contributor
JoanFM commented Jun 28, 2022

Why is this needed? it seems to break quite a lot

@JoanFM JoanFM merged commit 4a201bf into master Jun 28, 2022
@JoanFM JoanFM deleted the fix-import-module branch June 28, 2022 13:03
samsja pushed a commit that referenced this pull request Jun 29, 2022
@hanxiao
fix(import): remove early check file exist (#4977)
6a46bb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase component/jaml size/S size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @JoanFM
0