8000 fix: fix monitoring update of metrics on exception by JoanFM · Pull Request #4974 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix monitoring update of metrics on exception #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2022
Merged

fix: fix monitoring update of metrics on exception #4974

merged 3 commits into from
Jun 28, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 27, 2022 •
edited
Loading

Goals:

When requests fail due to connection errors, the metrics related do not get updated

@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Jun 27, 2022
@codecov
Copy link
codecov bot commented Jun 27, 2022 •
edited
Loading

Codecov Report

Merging #4974 (cb1e3f0) into master (e33513e) will decrease coverage by 1.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4974      +/-   ##
==========================================
- Coverage   87.83%   86.38%   -1.45%     
==========================================
  Files         111      111              
  Lines        8763     8771       +8     
==========================================
- Hits         7697     7577     -120     
- Misses       1066     1194     +128
Flag Coverage Δ
jina 86.38% <100.00%> (-1.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/request_handling.py 96.07% <100.00%> (+0.33%) ⬆️
jina/jaml/parsers/flow/v1.py 63.15% <0.00%> (-35.09%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
jina/orchestrate/flow/base.py 81.49% <0.00%> (-8.90%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 94.55% <0.00%> (-5.45%) ⬇️
jina/orchestrate/deployments/config/helper.py 91.22% <0.00%> (-3.51%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 91.53% <0.00%> (-3.08%) ⬇️
jina/logging/profile.py 92.59% <0.00%> (-2.47%) ⬇️
jina/jaml/helper.py 80.91% <0.00%> (-2.30%) ⬇️
jina/clients/base/http.py 93.15% <0.00%> (-1.37%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33513e...cb1e3f0. Read the comment docs.

@github-actions github-actions bot added the area/core This issue/PR affects the core codebase label Jun 28, 2022
@JoanFM JoanFM changed the title test: add test monitoring on failure fix: fix monitoring update of metrics on exception Jun 28, 2022
@JoanFM JoanFM marked this pull request as ready for review June 28, 2022 10:10
@JoanFM JoanFM requested a review from samsja June 28, 2022 10:10
@JoanFM JoanFM linked an issue Jun 28, 2022 that may be closed by this pull request
Monitoring: check pending request behavior with failing request #4973
Closed
samsja
samsja approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor
@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoanFM JoanFM merged commit 1d5271a into master Jun 28, 2022
@JoanFM JoanFM deleted the test-monitoring-on-failure branch June 28, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsja samsja samsja approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monitoring: check pending request behavior with failing request
2 participants
@JoanFM @samsja
0