8000 fix: add async dry run method by deepankarm · Pull Request #4963 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: add async dry run method #4963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2022
Merged

fix: add async dry run method #4963

merged 2 commits into from
Jun 24, 2022

Conversation

deepankarm
Copy link
Contributor

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/client labels Jun 24, 2022
JoanFM
JoanFM previously approved these changes Jun 24, 2022
View reviewed changes
@codecov
Copy link
codecov bot commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #4963 (b562a86) into master (12910c1) will increase coverage by 1.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4963      +/-   ##
==========================================
+ Coverage   86.54%   87.75%   +1.21%     
==========================================
  Files         111      111              
  Lines        8753     8756       +3     
==========================================
+ Hits         7575     7684     +109     
+ Misses       1178     1072     -106
Flag Coverage Δ
jina 87.75% <100.00%> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/http.py 100.00% <ø> (ø)
jina/__init__.py 64.63% <100.00%> (ø)
jina/clients/grpc.py 100.00% <100.00%> (ø)
jina/clients/mixin.py 92.85% <100.00%> (+1.49%) ⬆️
jina/clients/websocket.py 100.00% <100.00%> (ø)
jina/hubble/hubio.py 86.41% <0.00%> (-1.09%) ⬇️
jina/jaml/__init__.py 94.83% <0.00%> (+0.36%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.62%) ⬆️
jina/serve/runtimes/gateway/http/app.py 95.91% <0.00%> (+0.68%) ⬆️
jina/helper.py 80.93% <0.00%> (+0.75%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8de1a1...b562a86. Read the comment docs.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jun 24, 2022
@deepankarm deepankarm requested a review from JoanFM June 24, 2022 17:32
@hanxiao hanxiao merged commit ef961e9 into master Jun 24, 2022
@hanxiao hanxiao deleted the async-dryrun branch June 24, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepankarm @hanxiao @JoanFM
0