8000 fix: handle replicas in ui monitoring by samsja · Pull Request #4956 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

fix: handle replicas in ui monitoring #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2022
Merged

fix: handle replicas in ui monitoring #4956

merged 2 commits into from
Jun 24, 2022

Conversation

samsja
Copy link
Contributor
@samsja samsja commented Jun 24, 2022 •
edited
Loading

Context:

In the UI the port_monitoring of the replicas are not shown.

What this pr do

Fix the behavior and iterate over the pods to show the replicas port_monitoring

from jina import Flow

with Flow(monitoring=True).add(name='hello', port_monitoring=9090, replicas=2) as f:
    f.block()

Before
Screenshot from 2022-06-24 12-17-00

After
Screenshot from 2022-06-24 12-17-25

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Jun 24, 2022
@codecov
Copy link
codecov bot commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #4956 (fe8c432) into master (675f107) will decrease coverage by 6.71%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #4956      +/-   ##
==========================================
- Coverage   87.56%   80.85%   -6.72%     
==========================================
  Files         111      109       -2     
  Lines        8781     8742      -39     
==========================================
- Hits         7689     7068     -621     
- Misses       1092     1674     +582
Flag Coverage Δ
jina 80.85% <95.65%> (-6.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/flow/base.py 70.29% <95.65%> (-19.99%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 63.86% <0.00%> (-36.14%) ⬇️
jina/jaml/parsers/flow/v1.py 63.15% <0.00%> (-35.09%) ⬇️
jina/orchestrate/deployments/config/k8s.py 66.66% <0.00%> (-33.34%) ⬇️
jina/serve/runtimes/gateway/http/app.py 63.26% <0.00%> (-32.66%) ⬇️
...rate/deployments/config/k8slib/kubernetes_tools.py 73.80% <0.00%> (-26.20%) ⬇️
jina/orchestrate/deployments/config/helper.py 78.94% <0.00%> (-19.30%) ⬇️
jina/serve/runtimes/head/__init__.py 77.58% <0.00%> (-17.25%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675f107...fe8c432. Read the comment docs.

@hanxiao
Copy link
Member
hanxiao commented Jun 24, 2022

image

@hanxiao hanxiao merged commit 6eaf38b into master Jun 24, 2022
@hanxiao hanxiao deleted the feat-ui-monitoring-pods branch June 24, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsja @hanxiao
0