8000 feat: allow Executors as dataclass by JoanFM · Pull Request #4918 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: allow Executors as dataclass #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2022
Merged

feat: allow Executors as dataclass #4918

merged 4 commits into from
Jun 13, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 13, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM linked an issue Jun 13, 2022 that may be closed by this pull request
Support Executor dataclass besides classic init #4733
Closed
4 tasks
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/jaml labels Jun 13, 2022
@codecov
Copy link
codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #4918 (3db002c) into master (0338dcd) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4918      +/-   ##
==========================================
- Coverage   87.85%   87.79%   -0.07%     
==========================================
  Files         111      111              
  Lines        8754     8758       +4     
==========================================
- Hits         7691     7689       -2     
- Misses       1063     1069       +6
Flag Coverage Δ
jina 87.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 65.06% <100.00%> (ø)
jina/jaml/parsers/executor/legacy.py 91.66% <100.00%> (+0.49%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/orchestrate/flow/base.py 89.45% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86f8ad...3db002c. Read the comment docs.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jun 13, 2022
@github-actions github-actions bot added size/M area/docs This issue/PR affects the docs labels Jun 13, 2022
@JoanFM JoanFM marked this pull request as ready for review June 13, 2022 09:50
@JoanFM JoanFM closed this Jun 13, 2022
@JoanFM JoanFM reopened this Jun 13, 2022
JoanFM
JoanFM commented Jun 13, 2022
View reviewed changes
@JoanFM JoanFM force-pushed the executor-dataclass branch 3 times, most recently from 382be7d to 57066f0 Compare June 13, 2022 10:15
@JoanFM JoanFM force-pushed the executor-dataclass branch from 57066f0 to 3db002c Compare June 13, 2022 10:20
@github-actions
Copy link

📝 Docs are deployed on https://executor-dataclass--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 6f3a1f9 into master Jun 13, 2022
@JoanFM JoanFM deleted the executor-dataclass branch June 13, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsja samsja samsja approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/jaml size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Executor dataclass besides classic init
2 participants
@JoanFM @samsja
0