8000 feat: add jina info service to all Runtimes by JoanFM · Pull Request #4902 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add jina info service to all Runtimes #4902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 9, 2022
Merged

feat: add jina info service to all Runtimes #4902

merged 9 commits into from
Jun 9, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jun 9, 2022 •
edited
Loading

Goals:

The goal is to add services and endpoints for every runtime for Wolf to be able to pick which Jina version is running

  • Add it to HeadRuntime, WorkerRuntime, and all the Gateways
  • In HTTP change the response model
  • Add tests for every runtime
  • Add documentation

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/proto labels Jun 9, 2022
@JoanFM JoanFM linked an issue Jun 9, 2022 that may be closed by this pull request
jina -vf via endpoint for grpc / websocket gateways #4840
Closed
@codecov
Copy link
codecov bot commented Jun 9, 2022 •
edited
Loading

Codecov Report

Merging #4902 (f7ac0e6) into master (a697bdd) will increase coverage by 1.17%.
The diff coverage is 63.93%.

@@            Coverage Diff             @@
##           master    #4902      +/-   ##
==========================================
+ Coverage   86.64%   87.82%   +1.17%     
==========================================
  Files         111      111              
  Lines        8672     8753      +81     
==========================================
+ Hits         7514     7687     +173     
+ Misses       1158     1066      -92
Flag Coverage Δ
jina 87.82% <63.93%> (+1.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 80.93% <ø> (+0.75%) ⬆️
jina/serve/networking.py 86.36% <ø> (+0.23%) ⬆️
jina/proto/jina_pb2.py 54.73% <18.36%> (-3.93%) ⬇️
jina/proto/jina_pb2_grpc.py 76.00% <75.00%> (-0.20%) ⬇️
jina/__init__.py 65.06% <100.00%> (ø)
jina/proto/serializer.py 98.11% <100.00%> (+0.33%) ⬆️
jina/serve/runtimes/gateway/grpc/__init__.py 96.55% <100.00%> (+0.39%) ⬆️
jina/serve/runtimes/gateway/http/app.py 95.91% <100.00%> (+0.77%) ⬆️
jina/serve/runtimes/gateway/http/models.py 99.13% <100.00%> (-0.01%) ⬇️
jina/serve/runtimes/gateway/websocket/app.py 79.11% <100.00%> (+0.96%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a697bdd...f7ac0e6. Read the comment docs.

@JoanFM JoanFM force-pushed the expose-status-service branch from d64db52 to 6be134f Compare June 9, 2022 06:56
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jun 9, 2022
@github-actions github-actions bot added size/L area/docs This issue/PR affects the docs labels Jun 9, 2022
@JoanFM JoanFM force-pushed the expose-status-service branch from e8513ab to 9f80dc7 Compare June 9, 2022 09:36
@JoanFM JoanFM linked an issue Jun 9, 2022 that may be closed by this pull request
docs: Document usable ENV VARIABLES #4823
Closed
@JoanFM JoanFM marked this pull request as ready for review June 9, 2022 10:18
@JoanFM JoanFM requested a review from hanxiao as a code owner June 9, 2022 10:18
@JoanFM JoanFM force-pushed the expose-status-service branch from da34cc0 to fa57179 Compare June 9, 2022 10:35
JohannesMessner
JohannesMessner reviewed Jun 9, 2022
View reviewed changes
samsja
samsja reviewed Jun 9, 2022
View reviewed changes
@JoanFM JoanFM force-pushed the expose-status-service branch from 968f1e6 to 0147639 Compare June 9, 2022 11:05
@JohannesMessner
fix: apply suggestions from code review
ed060b3 
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
samsja
samsja approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor
@samsja samsja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
github-actions bot commented Jun 9, 2022

📝 Docs are deployed on https://expose-status-service--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit cd88dac into master Jun 9, 2022
@JoanFM JoanFM deleted the expose-status-service branch June 9, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesMessner JohannesMessner JohannesMessner approved these changes

@samsja samsja samsja approved these changes

@deepankarm deepankarm Awaiting requested review from deepankarm

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/proto size/L size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jina -vf via endpoint for grpc / websocket gateways docs: Document usable ENV VARIABLES
3 participants
@JoanFM @JohannesMessner @samsja
0