8000 refactor: rename cli to jina_cli by hanxiao · Pull Request #4890 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: rename cli to jina_cli #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 7, 2022
Merged

refactor: rename cli to jina_cli #4890

merged 6 commits into from
Jun 7, 2022

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 7, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@hanxiao hanxiao requested review from JoanFM and nan-wang as code owners June 7, 2022 12:49
@github-actions github-actions bot added size/S area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing labels Jun 7, 2022
@codecov
Copy link
codecov bot commented Jun 7, 2022 •
edited
Loading

Codecov Report

Merging #4890 (893034b) into master (abe735f) will decrease coverage by 5.17%.
The diff coverage is 56.84%.

@@            Coverage Diff             @@
##           master    #4890      +/-   ##
==========================================
- Coverage   88.18%   83.01%   -5.18%     
==========================================
  Files         110      111       +1     
  Lines        8481     8548      +67     
==========================================
- Hits         7479     7096     -383     
- Misses       1002     1452     +450
Flag Coverage Δ
jina 83.01% <56.84%> (-5.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__main__.py 0.00% <0.00%> (ø)
jina/exporter.py 0.00% <0.00%> (ø)
jina/serve/runtimes/base.py 74.19% <ø> (ø)
jina/parsers/export.py 87.17% <87.17%> (ø)
jina/hubble/hubio.py 86.41% <93.75%> (+0.07%) ⬆️
jina/helper.py 79.51% <100.00%> (-1.51%) ⬇️
jina/parsers/__init__.py 97.72% <100.00%> (ø)
jina/schemas/deployment.py 100.00% <100.00%> (ø)
jina/schemas/flow.py 100.00% <100.00%> (ø)
...a/orchestrate/deployments/config/docker_compose.py 63.86% <0.00%> (-36.14%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d2dd3...893034b. Read the comment docs.

@github-actions github-actions bot added the size/M label Jun 7, 2022
@hanxiao hanxiao closed this Jun 7, 2022
@hanxiao hanxiao reopened this Jun 7, 2022
@github-actions github-actions bot added the area/cicd This issue/PR affects the cicd pipeline label Jun 7, 2022
@hanxiao hanxiao merged commit 16b16b0 into master Jun 7, 2022
@hanxiao hanxiao deleted the refactor-cli-jina-cli branch June 7, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0