8000 refactor: remove hello worlds by hanxiao · Pull Request #4869 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove hello worlds #4869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 6, 2022
Merged

refactor: remove hello worlds #4869

merged 11 commits into from
Jun 6, 2022

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Jun 6, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@hanxiao hanxiao requested review from JoanFM and nan-wang as code owners June 6, 2022 11:36
@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing labels Jun 6, 2022
@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@hanxiao hanxiao closed this Jun 6, 2022
@hanxiao hanxiao reopened this Jun 6, 2022
@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov
Copy link
codecov bot commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #4869 (2d47145) into master (1b05b84) will decrease coverage by 2.36%.
The diff coverage is n/a.

❗ Current head 2d47145 differs from pull request most recent head 1874d99. Consider uploading reports for the commit 1874d99 to get more accurate results

@@            Coverage Diff             @@
##           master    #4869      +/-   ##
==========================================
- Coverage   85.79%   83.43%   -2.37%     
==========================================
  Files         119      110       -9     
  Lines        9042     8506     -536     
==========================================
- Hits         7758     7097     -661     
- Misses       1284     1409     +125
Flag Coverage Δ
jina 83.43% <ø> (-2.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/__init__.py 97.72% <ø> (-0.06%) ⬇️
jina/jaml/parsers/flow/v1.py 63.15% <0.00%> (-35.09%) ⬇️
jina/logging/profile.py 66.66% <0.00%> (-27.17%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
jina/orchestrate/flow/base.py 81.06% <0.00%> (-9.11%) ⬇️
jina/clients/base/grpc.py 80.39% <0.00%> (-7.85%) ⬇️
jina/clients/__init__.py 83.33% <0.00%> (-5.56%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 94.55% <0.00%> (-5.45%) ⬇️
jina/serve/runtimes/head/__init__.py 84.79% <0.00%> (-3.51%) ⬇️
jina/orchestrate/deployments/config/helper.py 94.73% <0.00%> (-3.51%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b05b84...1874d99. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added area/helper This issue/PR affects the helper functionality component/logging labels Jun 6, 2022
@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@hanxiao hanxiao closed this Jun 6, 2022
@hanxiao hanxiao reopened this Jun 6, 2022
@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
github-actions bot commented Jun 6, 2022

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@hanxiao hanxiao merged commit 5f06cff into master Jun 6, 2022
@hanxiao hanxiao deleted the refactor-rm-helloworld branch June 6, 2022 13:46
@github-actions
Copy link
github-actions bot commented Jun 6, 2022

📝 Docs are deployed on https://refactor-rm-helloworld--jina-docs.netlify.app 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM Awaiting requested review from JoanFM

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/logging component/resource size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0