8000 test: fix tests because join disappeared by JoanFM · Pull Request #4832 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: fix tests because join disappeared #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

test: fix tests because join disappeared #4832

merged 1 commit into from
May 26, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented May 26, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM marked this pull request as ready for review May 26, 2022 07:37
@github-actions github-actions bot added size/S area/testing This issue/PR affects testing 8000 labels May 26, 2022
@codecov
Copy link
codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #4832 (adc649f) into master (7ad728d) will increase coverage by 1.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4832      +/-   ##
==========================================
+ Coverage   86.92%   88.25%   +1.33%     
==========================================
  Files         119      119              
  Lines        9020     9020              
==========================================
+ Hits         7841     7961     +120     
+ Misses       1179     1059     -120
Flag Coverage Δ
jina 88.25% <ø> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/networking.py 89.14% <0.00%> (+0.25%) ⬆️
jina/jaml/__init__.py 94.79% <0.00%> (+0.37%) ⬆️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.64%) ⬆️
jina/serve/runtimes/gateway/http/app.py 92.48% <0.00%> (+0.75%) ⬆️
jina/helper.py 81.32% <0.00%> (+0.75%) ⬆️
jina/enums.py 88.07% <0.00%> (+0.91%) ⬆️
jina/clients/mixin.py 93.18% <0.00%> (+1.13%) ⬆️
jina/clients/base/http.py 95.31% <0.00%> (+1.56%) ⬆️
jina/jaml/helper.py 85.93% <0.00%> (+2.34%) ⬆️
jina/logging/profile.py 96.29% <0.00%> (+2.46%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae5d07...adc649f. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1298, delta to last 2 avg.: +7%
  • 🐎🐎 query QPS at 71, delta to last 2 avg.: +8%
  • 🐢🐢 avg flow time within 1.0114 seconds, delta to last 2 avg.: -15%
  • 😶 import jina within 0.486 seconds, delta to last 2 avg.: -3%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1298 71 1.0114 0.486
3.4.7 1346 74 0.9761 0.4567
3.4.6 1079 56 1.4158 0.5545

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 0a8a4fa into master May 26, 2022
@JoanFM JoanFM deleted the test-fix-join-needs branch May 26, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoanFM
0