8000 feat(executor): add self logger to executor by hanxiao · Pull Request #4818 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(executor): add self logger to executor #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

feat(executor): add self logger to executor #4818

merged 1 commit into from
May 23, 2022

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented May 23, 2022

Goals:

  • ...
  • ...
  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels May 23, 2022
@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1292, delta to last 2 avg.: +6%
  • 🐎🐎🐎🐎 query QPS at 78, delta to last 2 avg.: +14%
  • 🐎🐎 avg flow time within 1.6134 seconds, delta to last 2 avg.: +10%
  • 🐢🐢 import jina within 0.4577 seconds, delta to last 2 avg.: -14%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1292 78 1.6134 0.4577
3.4.4 1347 75 1.2709 0.4625
3.4.3 1072 61 1.6549 0.6107

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #4818 (a7ba30a) into master (aa2d7c8) will decrease coverage by 1.45%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4818      +/-   ##
==========================================
- Coverage   88.33%   86.87%   -1.46%     
==========================================
  Files         119      119              
  Lines        9024     9026       +2     
==========================================
- Hits         7971     7841     -130     
- Misses       1053     1185     +132
Flag Coverage Δ
jina 86.87% <66.66%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/executors/__init__.py 86.59% <66.66%> (+0.15%) ⬆️
jina/jaml/parsers/flow/v1.py 45.61% <0.00%> (-52.64%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
jina/orchestrate/flow/base.py 82.17% <0.00%> (-7.98%) ⬇️
jina/clients/__init__.py 83.33% <0.00%> (-5.56%) ⬇️
jina/clients/base/grpc.py 78.18% <0.00%> (-5.46%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 94.55% <0.00%> (-5.45%) ⬇️
jina/orchestrate/deployments/config/helper.py 94.73% <0.00%> (-3.51%) ⬇️
jina/serve/runtimes/gateway/__init__.py 86.20% <0.00%> (-3.45%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 91.47% <0.00%> (-3.11%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2d7c8...a7ba30a. Read the comment docs.

@hanxiao hanxiao merged commit 9c1fda9 into master May 23, 2022
@hanxiao hanxiao deleted the feat-add-logger branch May 23, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0