feat(hubble): executor push/pull user integration #4770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75c3366 to
9171fde
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #4770 +/- ##
==========================================
- Coverage 87.67% 87.65% -0.02%
==========================================
Files 119 119
Lines 8809 8832 +23
==========================================
+ Hits 7723 7742 +19
- Misses 1086 1090 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9171fde to
6b9dfbc
Compare
JoanFM
suggested changes
May 9, 2022
tests/unit/hubble/test_hubio.py
Outdated
| @@ -212,6 +223,41 @@ def _mock_post(url, data, headers=None, stream=True): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_push_with_authorization(mocker, monkeypatch, tmpdir): | |||
| clear_function_caches() | |||
| os.environ['JINA_HUB_ROOT'] = str(tmpdir) | |||
There was a problem hiding this comment.
u should use a fixture to make sure that this env variable is properly set and unset at the beginning and at the end of the test regardless of the success of failure of it
There was a problem hiding this comment.
I created auth_token fixture. Please check it out.
JoanFM
suggested changes
May 9, 2022
mapleeit
approved these changes
May 11, 2022
JoanFM
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions c
2B0B
annot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/jina-ai/hubble/issues/355