ci: add create-release.yml #4759
Conversation
Signed-off-by: mrtrkmn <mr.turkmen@icloud.com>
|
@jina-ai/team-core Be careful on reviewing it: once merged and if it breaks, be expecting that the community won't be very responsive to fixing it. |
Codecov Report
@@ Coverage Diff @@
## master #4759 +/- ##
==========================================
- Coverage 87.71% 87.60% -0.12%
==========================================
Files 119 119
Lines 8670 8809 +139
==========================================
+ Hits 7605 7717 +112
- Misses 1065 1092 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@mrtrkmn Thank you so much for the PR. Could you please address the comment?
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: benc-uk/workflow-dispatch@v1 | ||
| with: | ||
| workflow: Create Release | ||
| token: ${{ secrets.JINA_DEV_BOT }} | ||
| inputs: '{ "release_token": "${{ env.release_token }}", "triggered_by": "TAG"}' | ||
| env: | ||
| release_token: ${{ secrets.JINA_CORE_RELEASE_TOKEN }} |
There was a problem hiding this comment.
We run Manual Docker Build during TAG / CD & MANUAL. But create-release should only be triggered during TAG. That logic is missing here.
There was a problem hiding this comment.
Thanks a lot for your review @deepankarm.
I thought that if statement would be enough to resolve it. Like
if: startsWith(github.ref, 'refs/tags/v')I just wanted to be sure before pushing changes, what is your feedback on this ?
There was a problem hiding this comment.
Since triggered_by is passed in the input event, you can check if: "${{ github.event.inputs.triggered_by }}" == "TAG". I'm not very sure of the syntax, please validate it before pushing the commit.
There was a problem hiding this comment.
Thanks a lot for the hint @deepankarm .
I have checked the syntax by creating a dummy repo in my account and validated it.
Also checked through Github documentation.
There was a problem hiding this comment.
@mrtrkmn The PR looks good. I'll prefer merging it sometime next week though as this might have some follow up actions 🙂
There was a problem hiding this comment.
Great !
I am looking forward to see / contribute more on follow up actions or other parts of the repo :)
Thanks a lot @deepankarm :)
There was a problem hiding this comment.
@mrtrkmn We are merging your PR now and will handle the follow-up items, if any. Thank you so much.
| steps: | ||
| - uses: benc-uk/workflow-dispatch@v1 | ||
| if: ${{ inputs.triggered_by == 'TAG' }} |
There was a problem hiding this comment.
if: github.events.inputs.triggered_by == 'TAG'
Signed-off-by: mrtrkmn mr.turkmen@icloud.com
Goals:
fixes Publish Github release after Docker / pypi push #4748
check and update documentation. See guide and ask the team.