8000 feat: display all of the prometheus endpoint in ui by samsja · Pull Request #4758 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: display all of the prometheus endpoint in ui #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

feat: display all of the prometheus endpoint in ui #4758

merged 1 commit into from
May 9, 2022

Conversation

samsja
Copy link
Contributor
@samsja samsja commented May 6, 2022

Before:
Screenshot from 2022-05-06 15-08-23

After:

Screenshot from 2022-05-06 15-08-06

@samsja samsja requested review from JoanFM and JohannesMessner May 6, 2022 13:09
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels May 6, 2022
@samsja samsja linked an issue May 6, 2022 that may be closed by this pull request
show every prometheus endpoint in the ui #4757
Closed
@github-actions
Copy link
github-actions bot commented May 6, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1116, delta to last 2 avg.: -18%
  • 🐢🐢 query QPS at 56, delta to last 2 avg.: -23%
  • 🐎🐎🐎🐎 avg flow time within 1.9709 seconds, delta to last 2 avg.: +51%
  • 🐎🐎🐎🐎 import jina within 0.5759 seconds, delta to last 2 avg.: +25%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1116 56 1.9709 0.5759
3.3.25 1429 75 1.2792 0.4619
3.3.24 1295 71 1.3196 0.453

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented May 6, 2022 •
edited
Loading

Codecov Report

Merging #4758 (790e4ca) into master (c1f0ae5) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4758      +/-   ##
==========================================
- Coverage   87.71%   87.63%   -0.08%     
==========================================
  Files         119      119              
  Lines        8670     8672       +2     
==========================================
- Hits         7605     7600       -5     
- Misses       1065     1072       +7
Flag Coverage Δ
jina 87.63% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 65.88% <100.00%> (ø)
jina/orchestrate/flow/base.py 89.18% <100.00%> (-1.00%) ⬇️
jina/serve/networking.py 88.02% <100.00%> (+1.04%) ⬆️
...deployments/config/k8slib/kubernetes_deployment.py 52.08% <0.00%> (-6.25%) ⬇️
...a/orchestrate/deployments/config/docker_compose.py 99.00% <0.00%> (-1.00%) ⬇️
jina/serve/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01dc9da...790e4ca. Read the comment docs.

@JoanFM JoanFM merged commit a2cbd8e into master May 9, 2022
@JoanFM JoanFM deleted the feat-ui-monitoring branch May 9, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show every prometheus endpoint in the ui
2 participants
@samsja @JoanFM
0