8000 fix(flow): early stop at flow start by hanxiao · Pull Request #4726 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(flow): early stop at flow start #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2022
Merged

fix(flow): early stop at flow start #4726

merged 1 commit into from
Apr 30, 2022

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Apr 30, 2022

close #4563

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase labels Apr 30, 2022
@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1057, delta to last 2 avg.: +1%
  • 😶 query QPS at 54, delta to last 2 avg.: +1%
  • 🐎🐎🐎🐎 avg flow time within 1.996 seconds, delta to last 2 avg.: +16%
  • 😶 import jina within 0.5889 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1057 54 1.996 0.5889
3.3.21 1003 50 1.4555 0.6143
3.3.20 1069 55 1.9805 0.554

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #4726 (73e09e0) into master (55d1f44) will decrease coverage by 1.76%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #4726      +/-   ##
==========================================
- Coverage   87.85%   86.09%   -1.77%     
==========================================
  Files         119      119              
  Lines        8630     8628       -2     
==========================================
- Hits         7582     7428     -154     
- Misses       1048     1200     +152
Flag Coverage Δ
jina 86.09% <90.00%> (-1.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/excepts.py 100.00% <ø> (ø)
jina/hubble/hubio.py 86.02% <ø> (ø)
jina/orchestrate/flow/base.py 81.87% <88.88%> (-8.51%) ⬇️
jina/__init__.py 65.88% <100.00%> (-0.79%) ⬇️
jina/helloworld/fashion/helper.py 93.13% <100.00%> (-0.14%) ⬇️
jina/jaml/parsers/flow/v1.py 45.61% <0.00%> (-52.64%) ⬇️
jina/jaml/parsers/__init__.py 75.60% <0.00%> (-17.08%) ⬇️
jina/orchestrate/deployments/config/helper.py 91.22% <0.00%> (-7.02%) ⬇️
...deployments/config/k8slib/kubernetes_deployment.py 52.08% <0.00%> (-6.25%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5152c98...73e09e0. Read the comment docs.

@hanxiao hanxiao merged commit 1516c27 into master Apr 30, 2022
@hanxiao hanxiao deleted the fix-early-stop branch April 30, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Early fail of a Flow if one of the executor fails
1 participant
@hanxiao
0