8000 chore: remove legacy codebooks and figures by bwanglzu · Pull Request #4530 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove legacy codebooks and figures #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2022
Merged

chore: remove legacy codebooks and figures #4530

merged 1 commit into from
Mar 23, 2022

Conversation

bwanglzu
Copy link
Member

This PR removes jina 2.0 codebooks and figures under .github/2.0 folder. Also checked docs and docstrings, these files and figures are not being used anymore.

@github-actions github-actions bot added size/L area/housekeeping This issue/PR is housekeeping labels Mar 23, 2022
@codecov
Copy link
codecov bot commented Mar 23, 2022 •
edited
Loading

Codecov Report

Merging #4530 (55e1623) into master (dd5f08e) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4530      +/-   ##
==========================================
- Coverage   88.38%   88.34%   -0.05%     
==========================================
  Files         116      116              
  Lines        8484     8484              
==========================================
- Hits         7499     7495       -4     
- Misses        985      989       +4
Flag Coverage Δ
daemon 41.95% <ø> (-0.02%) ⬇️
jina 88.09% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/orchestrate/deployments/config/helper.py 94.64% <0.00%> (-3.58%) ⬇️
jina/orchestrate/pods/jinad.py 93.07% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5f08e...55e1623. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1230, delta to last 2 avg.: +17%
  • 🐎🐎🐎🐎 query QPS at 68, delta to last 2 avg.: +35%
  • 🐢🐢 avg flow time within 1.0682 seconds, delta to last 2 avg.: -36%
  • 🐢🐢 import jina within 0.4031 seconds, delta to last 2 avg.: -16%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1230 68 1.0682 0.4031
3.2.8 1071 50 1.6637 0.4704
3.2.7 1016 49 1.7253 0.4944

Backed by latency-tracking. Further commits will update this comment.

@bwanglzu bwanglzu requested a review from JoanFM March 23, 2022 14:59
@JoanFM JoanFM merged commit e036747 into master Mar 23, 2022
@JoanFM JoanFM deleted the chore-remove-legacy branch March 23, 2022 15:19
bwanglzu added a commit that referenced this pull request Mar 25, 2022
@bwanglzu
Revert "chore: remove legacy codebooks and figures (#4530)"
69fcdd5 
This reverts commit e036747.
@bwanglzu bwanglzu mentioned this pull request Mar 25, 2022
Merged
JoanFM pushed a commit that referenced this pull request Mar 25, 2022
@bwanglzu
Revert "chore: remove legacy codebooks and figures" (#4546)
c8ce3b3 
* Revert "chore: remove legacy codebooks and figures (#4530)"

This reverts commit e036747.

* chore: remove unused files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees
No one assigned
Labels
area/housekeeping This issue/PR is housekeeping size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwanglzu @JoanFM
0