8000 Fix better enum formatting by samsja · Pull Request #4520 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix better enum formatting #4520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2022
Merged

Fix better enum formatting #4520

merged 3 commits into from
Mar 21, 2022

Conversation

samsja
Copy link
Contributor
@samsja samsja commented Mar 21, 2022 •
edited
Loading

FIx the issue with the printing of our BetterEnum

Before :
Screenshot from 2022-03-21 08-58-29

After :
Screenshot from 2022-03-21 09-01-07

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Mar 21, 2022
@codecov
Copy link
codecov bot commented Mar 21, 2022 •
edited
Loading

Codecov Report

Merging #4520 (ec98289) into master (a470ce6) will increase coverage by 0.24%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #4520      +/-   ##
==========================================
+ Coverage   88.07%   88.32%   +0.24%     
==========================================
  Files         116      116              
  Lines        8528     8417     -111     
==========================================
- Hits         7511     7434      -77     
+ Misses       1017      983      -34
Flag Coverage Δ
daemon 42.09% <80.00%> (-0.94%) ⬇️
jina 88.07% <80.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/websocket/app.py 86.95% <ø> (ø)
jina/enums.py 94.11% <77.77%> (-1.38%) ⬇️
jina/__init__.py 67.46% <100.00%> (ø)
jina/clients/mixin.py 92.77% <0.00%> (-0.49%) ⬇️
jina/orchestrate/deployments/config/helper.py 98.21% <0.00%> (-0.07%) ⬇️
jina/orchestrate/flow/base.py 91.46% <0.00%> (-0.05%) ⬇️
jina/parsers/orchestrate/base.py 100.00% <0.00%> (ø)
jina/serve/runtimes/gateway/__init__.py 100.00% <0.00%> (ø)
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (ø)
...a/orchestrate/deployments/config/docker_compose.py 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075b3a9...ec98289. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1311, delta to last 2 avg.: +14%
  • 🐎🐎🐎🐎 query QPS at 68, delta to last 2 avg.: +36%
  • 🐢🐢 avg flow time within 1.3195 seconds, delta to last 2 avg.: -18%
  • 😶 import jina within 0.3951 seconds, delta to last 2 avg.: -4%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 1311 68 1.3195 0.3951
3.2.6 1089 47 1.6371 0.4154
3.2.5 1208 52 1.6024 0.408

Backed by latency-tracking. Further commits will update this comment.

@samsja samsja merged commit 63d7813 into master Mar 21, 2022
@samsja samsja deleted the fix-better-enum-formatting branch March 21, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao hanxiao approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsja @hanxiao
0