8000 fix: fix asyncclient return by JoanFM · Pull Request #4491 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix asyncclient return #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 16, 2022
Merged

fix: fix asyncclient return #4491

merged 3 commits into from
Mar 16, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Mar 16, 2022

Pull Request Title

Description

Please describe what your PR is doing and why. Are there any parts which need extra attention during review? Are there any dependencies from other PRs or projcts? Is this a breaking change?

Is this PR ready or work in progress (WIP)? Ready means it can be reviewed and merged from the author's perspective. If the PR is WIP: Make it a draft PR and state open questions and TODO items.

Closes # (issue)

@JoanFM JoanFM linked an issue Mar 16, 2022 that may be closed by this pull request
AsyncClient implementation is not up-to-date and inconsistent with Client #4489
Closed
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/client labels Mar 16, 2022
@JoanFM JoanFM force-pushed the fix-asyncclient-interface branch from 0249847 to f3c4275 Compare March 16, 2022 08:26
@github-actions
Copy link
github-actions bot commented Mar 16, 2022 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 897, delta to last 2 avg.: -2%
  • 😶 query QPS at 34, delta to last 2 avg.: -5%
  • 🐢🐢 avg flow time within 1.394 seconds, delta to last 2 avg.: -21%
  • 😶 import jina within 0.5684 seconds, delta to last 2 avg.: +3%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 897 34 1.394 0.5684
3.2.0 942 36 1.7714 0.5615
3.1.6 907 35 1.7937 0.5346

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #4491 (2653382) into master (ceb5108) will increase coverage by 0.62%.
The diff coverage is 98.11%.

@@            Coverage Diff             @@
##           master    #4491      +/-   ##
==========================================
+ Coverage   86.89%   87.51%   +0.62%     
==========================================
  Files         116      116              
  Lines        8423     8458      +35     
==========================================
+ Hits         7319     7402      +83     
+ Misses       1104     1056      -48
Flag Coverage Δ
daemon 43.33% <56.60%> (+<0.01%) ⬆️
jina 87.26% <98.11%> (+7.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/gateway/request_handling.py 96.22% <93.33%> (-1.34%) ⬇️
jina/__init__.py 67.46% <100.00%> (ø)
jina/clients/mixin.py 92.59% <100.00%> (+0.18%) ⬆️
jina/orchestrate/flow/base.py 91.50% <100.00%> (+5.12%) ⬆️
jina/parsers/orchestrate/deployment.py 100.00% <100.00%> (ø)
jina/parsers/orchestrate/runtimes/remote.py 100.00% <100.00%> (ø)
jina/parsers/orchestrate/runtimes/worker.py 100.00% <100.00%> (ø)
jina/serve/runtimes/gateway/__init__.py 100.00% <100.00%> (ø)
...ina/serve/runtimes/gateway/graph/topology_graph.py 100.00% <100.00%> (ø)
jina/types/request/data.py 97.97% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2acd11...2653382. Read the comment docs.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Mar 16, 2022
@JoanFM JoanFM marked this pull request as ready for review March 16, 2022 09:15
@JoanFM JoanFM requested a review from jacobowitz March 16, 2022 09:15
@JoanFM JoanFM force-pushed the fix-asyncclient-interface branch from 7a163be to 2653382 Compare March 16, 2022 09:29
jacobowitz
jacobowitz approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please change the PR description to something meaningful :)
I think its helpful for later documentation, especially for public facing things like this?

@JoanFM JoanFM merged commit 0df5719 into master Mar 16, 2022
@JoanFM JoanFM deleted the fix-asyncclient-interface branch March 16, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/client size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncClient implementation is not up-to-date and inconsistent with Client
2 participants
@JoanFM @jacobowitz
0