8000 feat: input filters for executors by JohannesMessner · Pull Request #4472 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: input filters for executors #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Mar 15, 2022
Merged

feat: input filters for executors #4472

merged 61 commits into from
Mar 15, 2022

Conversation

JohannesMessner
Copy link
Contributor
@JohannesMessner JohannesMessner commented Mar 14, 2022 •
edited
Loading

Migrated form here: #4373

Still To-Do:

  • Wait for official release of DocArray query language
    • Insert links to DocArray documentation in Jina documentation page and how-to
    • Insert required Jina version in Documentation
    • Bump DocArray version in requirements
    • Align parameter naming with DocArray naming convention
    • Align wording in docs/how-to with DocArray naming convention
    • (Optional?) Add filter visualization to flow.plot()
  • fix latency tracking

Joan Fontanals Martinez and others added 30 commits February 18, 2022 16:53
feat: add switch-like behavior
5c3e772
@jina-bot
style: fix overload and cli autocomplete
c436a47
test: add tests of topology graph
26d8a2f
Merge branch 'master' of https://github.com/jina-ai/jina into switch-…
c57356e 
…condition
test: add basic tests of conditions in graph
3c3ab4f
Merge branch 'master' of https://github.com/jina-ai/jina into switch-…
5db6fb6 
…condition
feat: add condition arg to deployment
1c2002e
@jina-bot
style: fix overload and cli autocomplete
79758da
@jina-bot
style: fix overload and cli autocomplete
595d105
feat: condition is singular
0c22ed6
Merge branch 'switch-condition' of https://github.com/jina-ai/jina in…
21ba842 
…to switch-condition
@jina-bot
style: fix overload and cli autocomplete
2785ea1
refactor: change conditions to graph conditions
d6859ff
@jina-bot
style: fix overload and cli autocomplete
108550e
refactor: refactor the gateway naming
7722da9
refactor: dict not well handled by parser
8dedc48
test: add integration test for feature
2a4788e
docs: add docs for feature
60bb7d3
feat: implement filter in reducing
a7a90b4
@JohannesMessner
fix: use docarrays query language for filtering
bf5fc69
@JohannesMessner
feat: implement sorting logic for docs returned after filtering
08e3dc4
@JohannesMessner
test: add test for sorting response docs
06306dd
@JohannesMessner
refactor: remove wrapper around filter condition
09abd5b
@JohannesMessner
test: rename test function
8fe9e38
@JohannesMessner
docs: add description for condition
a6508f5
@JohannesMessner
docs: first draft of switch how-to
74dd9d6
@JohannesMessner
docs: add howto to toctree
72e9bda
@JohannesMessner
chore: fix merge conflict
f04eef8
@jina-bot
style: fix overload and cli autocomplete
0cf5f2e
@JohannesMessner
docs: add link to how-to
f271751
samsja
samsja previously approved these changes Mar 15, 2022
View reviewed changes
@JohannesMessner JohannesMessner changed the title feat: document filters for executors feat: input filters for executors Mar 15, 2022
@github-actions github-actions bot added area/setup This issue/PR affects setting up Jina component/resource labels Mar 15, 2022
@github-actions
Copy link

📝 Docs are deployed on https://switch-condition--jina-docs.netlify.app 🎉

@github-actions
Copy link
github-actions bot commented Mar 15, 2022 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 930, delta to last 2 avg.: -15%
  • 🐢🐢 query QPS at 35, delta to last 2 avg.: -19%
  • 🐎🐎🐎🐎 avg flow time within 1.7921 seconds, delta to last 2 avg.: +13%
  • 🐎🐎🐎🐎 import jina within 0.521 seconds, delta to last 2 avg.: +14%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 930 35 1.7921 0.521
3.1.6 1061 38 1.7178 0.4452
3.1.5 1148 48 1.4486 0.4632

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM marked this pull request as ready for review March 15, 2022 16:05
@JoanFM JoanFM requested review from hanxiao and nan-wang as code owners March 15, 2022 16:05
@github-actions
Copy link

📝 Docs are deployed on https://switch-condition--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit a27ea8a into master Mar 15, 2022
@JoanFM JoanFM deleted the switch-condition branch March 15, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@samsja samsja samsja left review comments

@cristianmtr cristianmtr Awaiting requested review from cristianmtr

@hanxiao 6D47 hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/resource component/type size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohannesMessner @JoanFM @samsja @jina-bot
0