feat(hubble): upgrade to api v2 #4269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4269 +/- ##
==========================================
- Coverage 87.73% 87.46% -0.28%
==========================================
Files 113 113
Lines 8254 8299 +45
==========================================
+ Hits 7242 7259 +17
- Misses 1012 1040 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
a878c91 to
6b5bdc8
Compare
6b5bdc8 to
c08693b
Compare
JoanFM
reviewed
Feb 11, 2022
| if payload and isinstance(payload, dict): | ||
| msg = payload.get('message') | ||
|
|
||
| if 'Process(docker) exited on non-zero code' in msg: |
There was a problem hiding this comment.
This is not really a good way to decide anything
There was a problem hiding this comment.
@delgermurun @nomagick Could we move this detection to server side and also using status code instead of message to detect the error somehow?
samsja
pushed a commit
that referenced
this pull request
Feb 15, 2022
* feat(hubble): upgrade "fetch_meta" to api v2 * feat(hubble): upgrade pull & push to api v2 * feat(hubble): upgraded tests to api v2 Co-authored-by: Delgermurun Purevkhuu <492616+delgermurun@users.noreply.github.com>
samsja
pushed a commit
that referenced
this pull request
Feb 15, 2022
* feat(hubble): upgrade "fetch_meta" to api v2 * feat(hubble): upgrade pull & push to api v2 * feat(hubble): upgraded tests to api v2 Co-authored-by: Delgermurun Purevkhuu <492616+delgermurun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/jina-ai/hubble/issues/211