8000 refactor: remove replica id by JohannesMessner · Pull Request #4162 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: remove replica id #4162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jan 17, 2022
Merged

refactor: remove replica id #4162

merged 17 commits into from
Jan 17, 2022

Conversation

JohannesMessner
Copy link
Contributor

No description provided.

@JoanFM JoanFM changed the title Feat remove replica id feat: remove replica id Jan 11, 2022
@JoanFM JoanFM changed the title feat: remove replica id refactor: remove replica id Jan 11, 2022
@github-actions github-actions bot added area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/network This issue/PR affects network functionality component/executor component/peapod executor/meta labels Jan 11, 2022
JoanFM
JoanFM reviewed Jan 11, 2022
View reviewed changes
@codecov
Copy link
codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #4162 (f31065d) into master (def0a12) will increase coverage by 0.38%.
The diff coverage is 88.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4162      +/-   ##
==========================================
+ Coverage   86.53%   86.91%   +0.38%     
==========================================
  Files         118      120       +2     
  Lines        8338     8560     +222     
==========================================
+ Hits         7215     7440     +225     
+ Misses       1123     1120       -3
Flag Coverage Δ
daemon 40.93% <39.28%> (-1.18%) ⬇️
jina 84.91% <85.07%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/base.py 60.00% <0.00%> (ø)
jina/types/request/__init__.py 100.00% <ø> (ø)
jina/proto/jina_pb2.py 58.10% <3.33%> (ø)
jina/clients/mixin.py 90.47% <25.00%> (ø)
jina/flow/builder.py 80.00% <33.33%> (ø)
jina/parsers/helper.py 45.18% <50.00%> (-0.34%) ⬇️
jina/peapods/runtimes/__init__.py 61.11% <54.54%> (ø)
jina/clients/base/helper.py 85.71% <60.00%> (ø)
jina/peapods/runtimes/head/__init__.py 91.85% <61.53%> (+4.06%) ⬆️
jina/clients/request/__init__.py 73.91% <66.66%> (ø)
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fee0a...f31065d. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Jan 11, 2022 •
edited
Loading

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1552, delta to last 2 avg.: +33%
  • 🐎🐎🐎🐎 query QPS at 25, delta to last 2 avg.: +22%
  • 🐎🐎🐎🐎 dam extend QPS at 50084, delta to last 2 avg.: +56%
  • 🐎🐎🐎🐎 avg flow time within 1.3803 seconds, delta to last 2 avg.: +10%
  • 🐢🐢 import jina within 0.3075 seconds, delta to last 2 avg.: -30%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1552 25 50084 1.3803 0.3075
2.6.4 1150 20 30224 1.2934 0.4445
2.6.3 1171 20 33816 1.1987 0.44

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jan 13, 2022
JohannesMessner
JohannesMessner commented Jan 14, 2022
View reviewed changes
@JohannesMessner JohannesMessner reopened this Jan 17, 2022
@JohannesMessner JohannesMessner marked this pull request as ready for review January 17, 2022 08:27
@github-actions
Copy link

📝 Docs are deployed on https://feat-remove-replica-id-363--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 10c577a into master Jan 17, 2022
@JoanFM JoanFM deleted the feat-remove-replica-id-363 branch January 17, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/executor component/peapod executor/meta size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesMessner @JoanFM
0