8000 refactor: create orchestrate and serve modules by JoanFM · Pull Request #4168 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: create orchestrate and serve modules #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 20, 2022
Merged

refactor: create orchestrate and serve modules #4168

merged 13 commits into from
Jan 20, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jan 12, 2022

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/jaml labels Jan 12, 2022
@codecov
Copy link
codecov bot commented Jan 12, 2022 •
edited
Loading

Codecov Report

Merging #4168 (00a4f0b) into master (62745a7) will increase coverage by 1.36%.
The diff coverage is 85.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4168      +/-   ##
==========================================
+ Coverage   86.14%   87.50%   +1.36%     
==========================================
  Files         115      114       -1     
  Lines        8305     8302       -3     
==========================================
+ Hits         7154     7265     +111     
+ Misses       1151     1037     -114
Flag Coverage Δ
daemon 42.49% <64.34%> (-0.09%) ⬇️
jina 86.70% <85.21%> (+7.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/enums.py 96.64% <ø> (ø)
jina/jaml/parsers/base.py 60.00% <0.00%> (ø)
jina/orchestrate/flow/builder.py 80.00% <0.00%> (ø)
jina/orchestrate/peas/container_helper.py 73.80% <ø> (ø)
jina/orchestrate/pods/config/helper.py 96.15% <ø> (ø)
...orchestrate/pods/config/k8slib/kubernetes_tools.py 100.00% <ø> (ø)
jina/serve/executors/metas.py 100.00% <ø> (ø)
jina/serve/networking.py 83.73% <ø> (ø)
jina/serve/runtimes/base.py 74.19% <ø> (ø)
jina/serve/runtimes/gateway/http/models.py 99.14% <ø> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62745a7...00a4f0b. Read the comment docs.

@github-actions github-actions bot added area/cli This issue/PR affects the command line interface area/daemon area/docs This issue/PR affects the docs area/network This issue/PR affects network functionality component/peapod labels Jan 12, 2022
@github-actions
Copy link
github-actions bot commented Jan 12, 2022 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 757, delta to last 2 avg.: -46%
  • 🐎🐎🐎🐎 query QPS at 36, delta to last 2 avg.: +29%
  • 🐎🐎🐎🐎 avg flow time within 1.8276 seconds, delta to last 2 avg.: +56%
  • 🐎🐎 import jina within 0.4201 seconds, delta to last 2 avg.: +8%

Breakdown

Version Index QPS Query QPS Avg Flow Time (s) Import Time (s)
current 757 36 1.8276 0.4201
2.6.4 1496 29 1.2709 0.3584
2.6.3 1317 26 1.0592 0.4158

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM changed the title refactor: move flow to orchestrate module refactor: create orchestrate and serve modules Jan 12, 2022
@JoanFM JoanFM requested a review from jacobowitz January 12, 2022 17:14
@JoanFM JoanFM force-pushed the refactor-orchestrate-serve branch from 2571ac2 to ac2101f Compare January 13, 2022 07:21
@JoanFM JoanFM force-pushed the refactor-orchestrate-serve branch from 69317a9 to 7d316fd Compare January 13, 2022 08:24
@github-actions github-actions bot removed the area/docs This issue/PR affects the docs label Jan 19, 2022
@github-actions
Copy link

📝 Docs are deployed on https://refactor-orchestrate-serve--jina-docs.netlify.app 🎉

@JoanFM JoanFM marked this pull request as ready for review January 20, 2022 09:28
@JoanFM JoanFM requested a review from hanxiao as a code owner January 20, 2022 09:28
@JoanFM JoanFM force-pushed the refactor-orchestrate-serve branch from 35cacbe to 325433a Compare January 20, 2022 09:29
@JoanFM JoanFM linked an issue Jan 20, 2022 that may be closed by this pull request
Refactor code structure #4156
Closed
jacobowitz
jacobowitz previously approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor
@jacobowitz jacobowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I think it makes a lot of sense to change the packages like this 👍

@JoanFM JoanFM merged commit 21e5daf into master Jan 20, 2022
@JoanFM JoanFM deleted the refactor-orchestrate-serve branch January 20, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz left review comments

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/daemon area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/jaml component/peapod component/type size/L size/M size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor code structure
2 participants
@JoanFM @jacobowitz
0