10000 fix: use INFO log level in k8s by JoanFM · Pull Request #4159 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use INFO log level in k8s #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix: use INFO log level in k8s #4159

merged 1 commit into from
Jan 12, 2022

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Jan 11, 2022

No description provided.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/resource labels Jan 11, 2022
@JoanFM JoanFM requested a review from jacobowitz January 11, 2022 16:00
@JoanFM JoanFM linked an issue Jan 11, 2022 that may be closed by this pull request
Make sure debug logs are disabled in K8s #4131
Closed
@github-actions
Copy link
github-actions bot commented Jan 11, 2022 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1041, delta to last 2 avg.: -21%
  • 🐢🐢 query QPS at 17, delta to last 2 avg.: -33%
  • 🐢🐢 dam extend QPS at 30649, delta to last 2 avg.: -20%
  • 🐢🐢 avg flow time within 1.926 seconds, delta to last 2 avg.: +45%
  • 😶 import jina within 0.434 seconds, delta to last 2 avg.: +5%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1041 17 30649 1.926 0.434
2.6.4 1134 20 31138 1.5581 0.4501
2.6.3 1524 29 45920 1.0898 0.3761

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link
codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #4159 (9e83525) into master (def0a12) will increase coverage by 0.99%.
The diff coverage is 97.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4159      +/-   ##
==========================================
+ Coverage   86.53%   87.52%   +0.99%     
==========================================
  Files         118      120       +2     
  Lines        8338     8578     +240     
==========================================
+ Hits         7215     7508     +293     
+ Misses       1123     1070      -53
Flag Coverage Δ
daemon 40.98% <0.73%> (-1.12%) ⬇️
jina 86.74% <97.04%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/parsers/peapods/pea.py 100.00% <ø> (ø)
...eapods/pods/config/k8slib/kubernetes_deployment.py 53.19% <ø> (-4.19%) ⬇️
jina/peapods/runtimes/head/__init__.py 91.85% <0.00%> (+4.06%) ⬆️
jina/peapods/pods/config/helper.py 88.46% <88.46%> (ø)
jina/flow/base.py 91.12% <100.00%> (+0.43%) ⬆️
jina/peapods/pods/config/docker_compose.py 100.00% <100.00%> (ø)
jina/peapods/pods/config/k8s.py 100.00% <100.00%> (+1.76%) ⬆️
jina/peapods/runtimes/worker/__init__.py 92.98% <0.00%> (-7.02%) ⬇️
jina/peapods/pods/__init__.py 85.49% <0.00%> (+0.43%) ⬆️
jina/peapods/peas/jinad.py 93.43% <0.00%> (+0.72%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a813b15...9e83525. Read the comment docs.

@JoanFM JoanFM force-pushed the k8s-disable-debug-logs branch from b59df72 to 9e83525 Compare January 11, 2022 16:35
@JoanFM JoanFM merged commit a088b37 into master Jan 12, 2022
@JoanFM JoanFM deleted the k8s-disable-debug-logs branch January 12, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobowitz jacobowitz jacobowitz approved these changes

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/resource size/S size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure debug logs are disabled in K8s
2 participants
@JoanFM @jacobowitz
0