8000 test: deduplicate test name by JoanFM · Pull Request #4020 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

8000 test: deduplicate test name #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2021
Merged

test: deduplicate test name #4020

merged 1 commit into from
Dec 3, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Dec 3, 2021

No description provided.

@github-actions github-actions bot added size/XS area/testing This issue/PR affects testing labels Dec 3, 2021
@codecov
Copy link
codecov bot commented Dec 3, 2021 •
edited
Loading

Codecov Report

Merging #4020 (e4b8733) into master (b501404) will increase coverage by 1.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4020      +/-   ##
==========================================
+ Coverage   78.20%   79.48%   +1.28%     
==========================================
  Files         183      183              
  Lines       12935    12935              
==========================================
+ Hits        10116    10282     +166     
+ Misses       2819     2653     -166
Flag Coverage Δ
daemon 43.25% <ø> (-0.02%) ⬇️
jina 76.32% <ø> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 87.17% <0.00%> (-3.42%) ⬇️
jina/clients/base/helper.py 85.48% <0.00%> (-3.23%) ⬇️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/peapods/networking.py 83.49% <0.00%> (+0.48%) ⬆️
jina/peapods/peas/__init__.py 79.78% <0.00%> (+1.06%) ⬆️
jina/helper.py 81.70% <0.00%> (+1.24%) ⬆️
jina/types/message/__init__.py 84.61% <0.00%> (+1.44%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/peapods/runtimes/zmq/zed.py 89.04% <0.00%> (+1.82%) ⬆️
jina/peapods/zmq/__init__.py 87.90% <0.00%> (+2.09%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f714db0...e4b8733. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Dec 3, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1525, delta to last 2 avg.: +24%
  • 🐎🐎🐎🐎 query QPS at 30, delta to last 2 avg.: +23%
  • 🐎🐎🐎🐎 dam extend QPS at 46503, delta to last 2 avg.: +23%
  • 🐎🐎🐎🐎 avg flow time within 1.0781 seconds, delta to last 2 avg.: -7%
  • 🐢🐢 import jina within 0.355 seconds, delta to last 2 avg.: -17%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1525 30 46503 1.0781 0.355
2.5.1 1313 27 41404 1.0967 0.417
2.5.0 1142 21 33916 1.2346 0.4396

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 721b179 into master Dec 3, 2021
@JoanFM JoanFM deleted the change-test-name branch December 3, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/testing This issue/PR affects testing size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoanFM
0