8000 fix(types): fix plot sprite by JoanFM · Pull Request #4025 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(types): fix plot sprite #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2021
Merged

fix(types): fix plot sprite #4025

merged 2 commits into from
Dec 4, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Dec 3, 2021

No description provided.

@github-actions github-actions bot added size/XS area/testing This issue/PR affects testing labels Dec 3, 2021
@codecov
Copy link
codecov bot commented Dec 3, 2021 •
edited
Loading

Codecov Report

Merging #4025 (89a0727) into master (01151e3) will increase coverage by 0.74%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
+ Coverage   78.69%   79.43%   +0.74%     
==========================================
  Files         183      183              
  Lines       12955    12956       +1     
==========================================
+ Hits        10195    10292      +97     
+ Misses       2760     2664      -96
Flag Coverage Δ
daemon 43.21% <33.33%> (-0.02%) ⬇️
jina 76.27% <33.33%> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/mixins/plot.py 11.81% <0.00%> (-0.10%) ⬇️
jina/__init__.py 70.23% <100.00%> (ø)
jina/peapods/runtimes/gateway/http/__init__.py 97.29% <0.00%> (-2.71%) ⬇️
jina/peapods/pods/__init__.py 81.23% <0.00%> (+0.19%) ⬆️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/peapods/networking.py 83.49% <0.00%> (+0.48%) ⬆️
jina/peapods/zmq/__init__.py 86.51% <0.00%> (+0.69%) ⬆️
jina/helper.py 81.70% <0.00%> (+0.88%) ⬆️
jina/peapods/runtimes/zmq/zed.py 88.12% <0.00%> (+1.36%) ⬆️
jina/types/message/__init__.py 84.61% <0.00%> (+1.44%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ca82e...89a0727. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Dec 3, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1121, delta to last 2 avg.: -17%
  • 🐢🐢 query QPS at 20, delta to last 2 avg.: -24%
  • 🐢🐢 dam extend QPS at 31389, delta to last 2 avg.: -22%
  • 🐢🐢 avg flow time within 1.6716 seconds, delta to last 2 avg.: +27%
  • 🐎🐎🐎🐎 import jina within 0.4771 seconds, delta to last 2 avg.: +20%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1121 20 31389 1.6716 0.4771
2.5.2 1397 25 39970 1.5238 0.3724
2.5.1 1327 27 40978 1.09 0.4219

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/type and removed area/testing This issue/PR affects testing labels Dec 3, 2021
@JoanFM JoanFM changed the title test: silence process map_batch fix(types): fix plot sprite Dec 3, 2021
@JoanFM JoanFM force-pushed the remove-map-batch-test-parallel branch from 2c9e790 to 89a0727 Compare December 3, 2021 17:28
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Dec 3, 2021
@hanxiao hanxiao merged commit c7353e5 into master Dec 4, 2021
@hanxiao hanxiao deleted the remove-map-batch-test-parallel branch December 4, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanFM @hanxiao
0