8000 fix(types): fix returning types and doc bot check by hanxiao · Pull Request #4019 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(types): fix returning types and doc bot check #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix(types): fix returning types and doc bot check #4019

merged 1 commit into from
Dec 2, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Dec 2, 2021

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/type labels Dec 2, 2021
@codecov
Copy link
codecov bot commented Dec 2, 2021 •
edited
Loading

Codecov Report

Merging #4019 (95cebc4) into master (6ad6b8d) will increase coverage by 1.60%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4019      +/-   ##
==========================================
+ Coverage   77.94%   79.54%   +1.60%     
==========================================
  Files         183      183              
  Lines       12934    12935       +1     
==========================================
+ Hits        10081    10289     +208     
+ Misses       2853     2646     -207
Flag Coverage Δ
daemon 43.25% <50.00%> (-0.02%) ⬇️
jina 76.37% <50.00%> (+2.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/mixins/sugar.py 37.50% <50.00%> (-1.64%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 87.17% <0.00%> (-1.71%) ⬇️
jina/peapods/pods/__init__.py 81.23% <0.00%> (+0.19%) ⬆️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/peapods/networking.py 83.49% <0.00%> (+0.48%) ⬆️
jina/types/document/__init__.py 75.26% <0.00%> (+0.69%) ⬆️
jina/types/message/__init__.py 84.61% <0.00%> (+1.44%) ⬆️
jina/helper.py 81.70% <0.00%> (+1.59%) ⬆️
jina/types/arrays/memmap/__init__.py 67.48% <0.00%> (+1.64%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ad6b8d...95cebc4. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Dec 2, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1574, delta to last 2 avg.: +29%
  • 🐎🐎🐎🐎 query QPS at 31, delta to last 2 avg.: +37%
  • 🐎🐎🐎🐎 dam extend QPS at 47886, delta to last 2 avg.: +39%
  • 🐎🐎🐎🐎 avg flow time within 1.3159 seconds, delta to last 2 avg.: -17%
  • 🐢🐢 import jina within 0.3515 seconds, delta to last 2 avg.: -25%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1574 31 47886 1.3159 0.3515
2.5.1 1285 23 37556 1.5614 0.4312
2.5.0 1141 21 31323 1.6447 0.5094

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit b501404 into master Dec 2, 2021
@hanxiao hanxiao deleted the fix-types branch December 2, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hanxiao
0