8000 feat(types): add embed and fromgen mixin to da & dam by hanxiao · Pull Request #4005 · jina-ai/serve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(types): add embed and fromgen mixin to da & dam #4005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 28, 2021
Merged

feat(types): add embed and fromgen mixin to da & dam #4005

merged 19 commits into from
Nov 28, 2021

Conversation

hanxiao
Copy link
Member
@hanxiao hanxiao commented Nov 28, 2021

No description provided.

@github-actions github-actions bot added size/XL area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/type labels Nov 28, 2021
@github-actions github-actions bot added area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Nov 28, 2021
@codecov
Copy link
codecov bot commented Nov 28, 2021 •
edited
Loading

Codecov Report

Merging #4005 (8e53932) into master (dee28db) will decrease coverage by 2.37%.
The diff coverage is 80.39%.

❗ Current head 8e53932 differs from pull request most recent head f971eb5. Consider uploading reports for the commit f971eb5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4005      +/-   ##
==========================================
- Coverage   88.46%   86.09%   -2.38%     
==========================================
  Files         180      182       +2     
  Lines       12671    12769      +98     
==========================================
- Hits        11210    10993     -217     
- Misses       1461     1776     +315
Flag Coverage Δ
daemon 43.66% <38.56%> (+0.01%) ⬆️
jina 85.62% <80.39%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/memmap/__init__.py 96.29% <ø> (+0.02%) ⬆️
jina/types/document/generators.py 89.09% <ø> (ø)
jina/types/document/mixins/image.py 67.62% <10.00%> (-4.47%) ⬇️
jina/types/arrays/mixins/io/common.py 66.66% <50.00%> (ø)
jina/types/arrays/mixins/io/csv.py 79.31% <50.00%> (+2.64%) ⬆️
jina/types/document/mixins/sugar.py 57.14% <50.00%> (ø)
jina/types/arrays/mixins/io/binary.py 83.87% <66.66%> (ø)
jina/types/arrays/mixins/io/json.py 87.50% <66.66%> (+3.50%) ⬆️
jina/types/arrays/mixins/io/from_gen.py 83.63% <83.63%> (ø)
jina/types/arrays/mixins/plot.py 85.13% <92.30%> (-0.40%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee28db...f971eb5. Read the comment docs.

@github-actions
Copy link
github-actions bot commented Nov 28, 2021 •
edited
Loading

Latency summary

Current PR yields:

  • 😶 index QPS at 1224, delta to last 2 avg.: +0%
  • 😶 query QPS at 22, delta to last 2 avg.: +0%
  • 😶 dam extend QPS at 36754, delta to last 2 avg.: +6%
  • 😶 avg flow time within 1.5418 seconds, delta to last 2 avg.: +0%
  • 😶 import jina within 0.4393 seconds, delta to last 2 avg.: -1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1224 22 36754 1.5418 0.4393
2.4.10 1184 21 32982 1.6161 0.4826
2.4.9 1248 22 35725 1.4898 0.4075

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit cb24d8a into master Nov 28, 2021
@hanxiao hanxiao deleted the docs-new-readme branch November 28, 2021 16:32
@github-actions
Copy link

📝 Docs are deployed on https://docs-new-readme--jina-docs.netlify.app 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/type size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxiao @jina-bot
0