8000 feat: add LightGBMRanker by JoanFM · Pull Request #3670 · jina-ai/jina-hub · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

feat: add LightGBMRanker #3670

Merged
8000
merged 21 commits into from
Mar 15, 2021
Merged

feat: add LightGBMRanker #3670

merged 21 commits into from
Mar 15, 2021

Conversation

JoanFM
Copy link
Contributor
@JoanFM JoanFM commented Feb 12, 2021 •
edited
Loading

This change motivates partially this other PR:

jina-ai/serve#1718

TODO in core

@JoanFM JoanFM marked this pull request as draft February 12, 2021 11:44
@JoanFM JoanFM marked this pull request as ready for review February 12, 2021 12:58
@JoanFM JoanFM mentioned this pull request Feb 12, 2021
Merged
@JoanFM JoanFM changed the title feat: add LambdaMartRanker ranker feat: add LightGBMRanker Feb 12, 2021
@JoanFM JoanFM marked this pull request as draft February 12, 2021 15:52
@JoanFM JoanFM marked this pull request as ready for review March 12, 2021 16:27
nan-wang
nan-wang suggested changes Mar 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

Joan Fontanals and others added 5 commits March 15, 2021 09:10
@nan-wang
fix: update rankers/LightGBMRanker/Dockerfile
f6cbda6 
Co-authored-by: Nan Wang <nan.wang@jina.ai>
@nan-wang
fix: update rankers/LightGBMRanker/Dockerfile
6abcd66 
Co-authored-by: Nan Wang <nan.wang@jina.ai>
@nan-wang
fix: update rankers/LightGBMRanker/README.md
9f77cdc 
Co-authored-by: Nan Wang <nan.wang@jina.ai>
@nan-wang
fix: update rankers/LightGBMRanker/__init__.py
54ed3e7 
Co-authored-by: Nan Wang <nan.wang@jina.ai>
@nan-wang
fix: update rankers/LightGBMRanker/Dockerfile
0f31916 
Co-authored-by: Nan Wang <nan.wang@jina.ai>
@JoanFM JoanFM requested a review from nan-wang March 15, 2021 09:01
nan-wang
nan-wang previously approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang
Copy link
Member

https://github.com/jina-ai/jina-hub/pull/3670/checks?check_run_id=2111078713#step:6:689

The model file is missing

@JoanFM
Copy link
Contributor Author
JoanFM commented Mar 15, 2021

https://github.com/jina-ai/jina-hub/pull/3670/checks?check_run_id=2111078713#step:6:689

The model file is missing

Check now
8000

nan-wang
nan-wang approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member
@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@nan-wang nan-wang merged commit 55124e1 into master Mar 15, 2021
@nan-wang nan-wang deleted the hub-lightgbm branch March 15, 2021 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nan-wang nan-wang nan-wang approved these changes

@maximilianwerk maximilianwerk Awaiting requested review from maximilianwerk

Assignees
No one assigned
Labels
component/ranker size/M tests type/config type/dockerfile type/manifest type/python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoanFM @nan-wang @jina-bot
0