Add option to change maximum number of SNPs in gbat tests #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The PR adds a new option,
--max-snps, that can be used to change the maximum number of SNPs tested in gbat tests. The default value is kept at 10,000 and this new option enables analysis for larger regions or very densely genotyped datasets. I was not sure if there is a naming convention for options that affect gene-based tests, but I am happy to change the current name if needed.This has been tested and works when running mBAT-combo on regions with more than 10,000 SNPs.
I also added a minor change to the
gcta_build_steps_linux.shto make and install the Spectra dependency.See issue: #49
Thanks,
-Jonathan