Microns 1366 -Search for #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shape the black tile when the actual tile data is corrupt.
… search Cloudwatch Logs for errors. Added the symbolic link to allow the lambda function to be imported into test scripts. Lambda is a reserved word so can't directly import that name.
|
Heres the original PR. I am working on a Test for the ingest_lambda but thought it would be helpful to get this out first and give you time to review. |
sandyhider
commented
Aug 4, 2018
| @@ -29,6 +29,8 @@ | |||
|
|
|||
| from botocore.exceptions import ClientError | |||
|
|
|||
| print("$$$ IN TILE UPLOAD LAMBDA $$$") | |||
There was a problem hiding this comment.
This is really unrelated but I found it helpful to be able to search multilambda logs for specific types of lambas. that is what this is giving us.
lrodri29
approved these changes
Aug 4, 2018
| else: | ||
| try: | ||
| tile_img = np.asarray(Image.open(image_bytes), dtype=dtype) | ||
| except TypeError as te: |
There was a problem hiding this comment.
Don’t really need to except as te since you’re not using te?
|
I tried the test it looks like there is a lot of things that need to be Mocked for this to work. I added another ticket to pull ingest_lambda.py out of multilambda, refactor so it isn't one large single function and then create unit test on the parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When corrupt tile images or zero length tile images are uploaded with the ingest client, it crashed the ingest_lambda.
Solution: Catch errors and use a ndarray of zeros. However we also need to shape the ndarray based off of the x and y tile dimensions.
Ingest lambda does not current have this information. It needs to be added to the s3 tile metadata.
This set of changes