8000 Handle trailing separators in header by joekamibeppu · Pull Request #154 · jhillyerd/enmime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle trailing separators in header #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

Handle trailing separators in header #154

merged 1 commit into from
May 24, 2020

Conversation

joekamibeppu
Copy link
Contributor
@joekamibeppu joekamibeppu commented May 22, 2020 •
edited
Loading

Hello. This is a fix for #153.

If my understanding is correct, here is what was happening. When the Content-Type header value was something like text/plain;, it would turn into text/plain;=not-a-param-value, then =not-a-param-value parsed on its own would cause a mime: invalid media parameter error in turn.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 95.546% when pulling 5ca68e0 on joekamibeppu:joekamibeppu/trailing-comma into 2505a64 on jhillyerd:develop.

@jhillyerd jhillyerd merged commit a78482f into jhillyerd:develop May 24, 2020
@jhillyerd
Copy link
Owner

Thanks!

@joekamibeppu joekamibeppu deleted the joekamibeppu/trailing-comma branch May 25, 2020 01:13
jhillyerd added a commit that referenced this pull request May 26, 2020
@jhillyerd
Merge tag 'v0.8.1' into develop
687195b 
Fixed

- Handle incorrectly indented headers (#149, thanks requaos)
- Handle trailing separator characters in header (#154, thanks joekamibeppu)

Changed

- enmime no longer uses git-flow, and will now accept PRs against master
david74chou added a commit to UmboCV/enmime that referenced this pull request Nov 9, 2020
@david74chou
Handle trailing separators in header
c0bcb53 
ref: jhillyerd#154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joekamibeppu @coveralls @jhillyerd
0